Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in non-generated API calls when printing as JSON #1095

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix panic in non-generated API calls when printing as JSON #1095

merged 1 commit into from
Apr 9, 2021

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Apr 9, 2021

Fixes #992

@jefferai jefferai added this to the 0.1.9 milestone Apr 9, 2021
@jefferai jefferai requested a review from schristoff April 9, 2021 15:37
@jefferai jefferai force-pushed the jeff-fix-json-panic branch from b8c7671 to a60b154 Compare April 9, 2021 15:38
schristoff
schristoff approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙 looks good

@jefferai jefferai merged commit f05f37d into main Apr 9, 2021
@jefferai jefferai deleted the jeff-fix-json-panic branch April 9, 2021 17:09
@jefferai jefferai modified the milestones: 0.1.9, 0.2.0 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
api/authmethods api/targets api core
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Format json error on authenticate password
2 participants
@jefferai @schristoff