Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove yarn audit check #573

Merged
merged 2 commits into from
May 25, 2021
Merged

Conversation

gsusmi
Copy link
Collaborator

@gsusmi gsusmi commented May 25, 2021

Json output option for yarn audit fails with error for moderate level audit check:

/usr/local/lib/node_modules/yarn/lib/cli.js:92452
  throw err;
  ^
Error: write ENOBUFS
    at afterWriteDispatched (internal/stream_base_commons.js:156:25)
    at writevGeneric (internal/stream_base_commons.js:139:3)
    at Socket._writeGeneric (net.js:785:11)
    at Socket._writev (net.js:794:8)
    at doWrite (_stream_writable.js:401:12)
    at clearBuffer (_stream_writable.js:519:5)
    at onwrite (_stream_writable.js:454:7)
    at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:103:10) {
  errno: 'ENOBUFS',
  code: 'ENOBUFS',
  syscall: 'write'
}

Yarn recommended solution to query by dependencies doesn't fix this issue in our repo. Removing yarn audit capability in favor of dependabot alerts.

Json output option for yarn audit is broken:
yarnpkg/yarn#7404
@gsusmi gsusmi requested review from a user and calcaide May 25, 2021 17:19
@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

boundary-ui – ./ui/admin

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui/11hkEvLba1ZeccDQjfuKKz1FqQUU
✅ Preview: https://boundary-ui-git-remove-yarn-audit-precommit-check-hashicorp.vercel.app

boundary-ui-storybook – ./addons/rose

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui-storybook/5w2wuzA1ze5gMg3DZs5s1afGBX61
✅ Preview: https://boundary-ui-st-git-remove-yarn-audit-precommit-check-ha-4c2e5c.vercel.app

boundary-ui-desktop – ./ui/desktop

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui-desktop/AdAnZqTPu2pWLaWXDoFNDSqrh14a
✅ Preview: https://boundary-ui-de-git-remove-yarn-audit-precommit-check-ha-aac737.vercel.app

@gsusmi
Copy link
Collaborator Author

gsusmi commented May 25, 2021

Security Audit check got removed in this PR but status checks UI in this PR still show that it is required. Merging should update github workflows.

@gsusmi gsusmi merged commit f254468 into main May 25, 2021
@gsusmi gsusmi deleted the remove-yarn-audit-precommit-check branch May 25, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant