Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMRE-396: support specifying recommended packages #27

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

shore
Copy link
Contributor

@shore shore commented Sep 9, 2024

This PR adds support for specifying recommended packages (request in NET-10747).

The test workflow has been updated to pass required and recommended dependencies, both can now be verified in the generated templates as well as in the package examination output.

Further, the generated packages are uploaded to the workflow run to facilitate local inspection.

@shore shore force-pushed the smre-396-recommended-packages branch 16 times, most recently from 48ffadb to ee3d245 Compare September 9, 2024 22:35
Copy link

@sarahethompson sarahethompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 this is fab Brian!

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@shore
Copy link
Contributor Author

shore commented Sep 11, 2024

Rebasing for tidy commit history

@shore shore force-pushed the smre-396-recommended-packages branch from 14c2ff5 to 8ba4089 Compare September 11, 2024 16:17
@shore shore merged commit 3332655 into main Sep 11, 2024
6 checks passed
@shore shore deleted the smre-396-recommended-packages branch September 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants