Packages support file permissions and ownership #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shore
force-pushed
the
bshore/packages-support-file-permissions-and-ownership
branch
from
1130ae8 to
81c4f37
Compare
shore
requested review from
a team and
sarahethompson
and removed request for
a team
jeanneryan
reviewed
Jun 11, 2024
|
|
||
| - name: dump RPM | ||
| run: | | ||
| echo "::group::maybe install rpm" 1>&2 |
There was a problem hiding this comment.
maybe install rpm
Is this a group name?
There was a problem hiding this comment.
Yup, the group is just to hide the output from the package install if it happens, because that's almost never a part of the output we'll want to see. Click the twisty in the unlikely event you want to see oodles of output from apt 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of SMRE-216, this PR adds inputs to the action so product teams can specify file ownership and permissions for the contents of the generated packages. These are global settings that apply to all files within the package, finer granularity is not supported at this time.
Self-test package results:
Note: while this PR fixes ownership and permissions validation failures for RPM packages, it does not address Linux Capabilities (
Pflag in outputs below). It appears nfpm is not capable of setting these values at this time.Sample verification outputs:
EL7:
# rpm -vV vault-enterprise ......... c /etc/vault.d/vault.env ......... c /etc/vault.d/vault.hcl ........P /usr/bin/vault ......... c /usr/lib/systemd/system/vault.servicefedora-40:
# rpm -vV vault-enterprise ......... c /etc/vault.d/vault.env ......... c /etc/vault.d/vault.hcl ........P /usr/bin/vault ......... c /usr/lib/systemd/system/vault.service