Fix search filtering #602
Merged
Fix search filtering #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Feb 20, 2024
| @@ -1,5 +1,5 @@ | |||
| {{page-title "Search Results"}} | |||
|
|
|||
| <Header::Toolbar @facets={{@facets}} /> | |||
| <Header::Toolbar @facets={{this.model.facets}} /> | |||
There was a problem hiding this comment.
This is the primary change
jfreda
approved these changes
Feb 20, 2024
For sure, I just need to do some cleanup first. Unfortunately we don't have any filter-based tests, so there isn't anything for me to work from. I have a PR coming soon that'll get us closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression causing filters to not appear on the
/resultsroute. Plus a little cleanup.