Improve pollForExpiredAuth and reauthenticate UX
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
/me polling and reauthenticate UX
jeffdaley
changed the title
/me polling and reauthenticate UXpollForExpiredAuth and reauthenticate UX
|
Moving to draft. Want to make sure the changes in #144 are accounted for here. |
jeffdaley
force-pushed
the
jeffdaley/fix-poll-errors
branch
from
b65d891 to
c8348cc
Compare
jeffdaley
commented
Apr 28, 2023
jfreda
reviewed
May 1, 2023
web/app/services/session.ts
Outdated
| }, | ||
| true | ||
| ); | ||
| // If the reauth message is shown, do nothing but restart the counter. |
There was a problem hiding this comment.
I'm thinking of a situation where a user has multiple Hermes tabs open and the session expires: can/should we continue polling to check to see if the me API starts returning a 200 again? This way when the user re-auths in one tab, the flash message will go away in all the other tabs?
jfreda
approved these changes
May 16, 2023
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Improve polling and reauthentication * Cleanup * Grammar fix * Revert test changes * Update authenticated-user.ts * Update tests, types and documentation * Cleanup and documentation * Improve type accuracy * Separate Okta/Google poll handling * Copy tweaks * Remove unnecessary polling rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
pollForExpiredAuthhandling as well as the reauthentication UX:Plus some tests and cleanup.