Separate front- and back-end redirect handling #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the redirect problem occurs when Ember Simple Auth reports a logged-in user but the back end does not. Here are a couple important logs of a failed attempt:
That error bubbles up to the application route where we invalidate the service. At this point, the app appears to reset, as evidenced by the deprecation warning that usually only appears on appLoad.
I don't have a full grasp of Ember internals, but here's my guess: The app doesn't know what to do after invalidating the session on a protected route, so it just blows itself up. (I'd do the same.) I'm thinking that by adding a redirect back to the auth screen, we might prevent this from happening.