Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy #982

remove circular dependency

4e7ad7e
Select commit
Loading
Failed to load commit list.
Merged

feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy #982

remove circular dependency
4e7ad7e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 1s

84.55% (+0.08%) compared to 3c3673a

View this Pull Request on Codecov

84.55% (+0.08%) compared to 3c3673a

Details

Codecov Report

Attention: Patch coverage is 98.79518% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (3c3673a) to head (4e7ad7e).

Files with missing lines Patch % Lines
src/commands/network.ts 93.93% 2 Missing ⚠️
src/core/helpers.ts 80.00% 1 Missing ⚠️
src/core/profile_manager.ts 99.20% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   84.46%   84.55%   +0.08%     
==========================================
  Files          72       74       +2     
  Lines       19560    19716     +156     
  Branches     1897     1286     -611     
==========================================
+ Hits        16521    16670     +149     
- Misses       2879     3036     +157     
+ Partials      160       10     -150     
Files with missing lines Coverage Δ
src/commands/node/configs.ts 96.72% <100.00%> (-0.26%) ⬇️
src/commands/node/tasks.ts 93.77% <100.00%> (-0.02%) ⬇️
src/core/account_manager.ts 86.73% <ø> (+0.07%) ⬆️
src/core/constants.ts 97.05% <100.00%> (+0.01%) ⬆️
...network_models/genesis_network_data_constructor.ts 100.00% <100.00%> (ø)
...etwork_models/genesis_network_node_data_wrapper.ts 100.00% <100.00%> (ø)
src/core/templates.ts 72.85% <100.00%> (+0.39%) ⬆️
version.ts 100.00% <ø> (ø)
src/core/helpers.ts 88.66% <80.00%> (+0.29%) ⬆️
src/core/profile_manager.ts 96.95% <99.20%> (+1.51%) ⬆️
... and 1 more

... and 28 files with indirect coverage changes

Impacted file tree graph