fix: resolve node delete test failures #865
Conversation
Signed-off-by: Nathan Klick <[email protected]>
nathanklick
added
Bug
| @@ -214,18 +214,20 @@ export class AccountManager { | |||
| * @returns a node client that can be used to call transactions | |||
| */ | |||
| async _getNodeClient (namespace: string, networkNodeServicesMap: Map<string, NetworkNodeServices>, operatorId: string, | |||
| operatorKey: string, useFirstNodeOnly = true) { | |||
| operatorKey: string, useSecondNodeOnly = true) { | |||
There was a problem hiding this comment.
what happens if they do a solo node delete but then delete the second node?
There was a problem hiding this comment.
also, I'm running locally with the new lower docker CPU and RAM settings, and the delete is failing before it gets to the delete subcommand
There was a problem hiding this comment.
It's a terrible trade off at the moment based on how and when this client is instantiated. Right now all the tests only delete the first node.
There was a problem hiding this comment.
so you added code to help a test case pass?
There was a problem hiding this comment.
It is a hacky fix until we untangle some other issues.
There was a problem hiding this comment.
wouldn't it have been easier to just change the test case to not delete node1?
There was a problem hiding this comment.
so you added code to help a test case pass?
No not exactly, it's also to provide some relief due to SDK Client issues.
Signed-off-by: Nathan Klick <[email protected]>
nathanklick
force-pushed
the
00864-Fix-Node-Delete-Tests
branch
from
37468ae to
cc48bf1
Compare
Description
This pull request changes the following:
_getNodeClientmethod to use the second node only by default.Related Issues