Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to inject a ca certificate for use in gRPC and gRPC Web #753

Apply suggestions from code review

0892da7
Select commit
Loading
Failed to load commit list.
Merged

feat: Add the ability to inject a ca certificate for use in gRPC and gRPC Web #753

Apply suggestions from code review
0892da7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 7, 2024 in 0s

86.16% (-0.93%) compared to b66fe05

View this Pull Request on Codecov

86.16% (-0.93%) compared to b66fe05

Details

Codecov Report

Attention: Patch coverage is 61.75772% with 161 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (b66fe05) to head (0892da7).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/core/certificate_manager.ts 49.50% 100 Missing and 3 partials ⚠️
src/commands/prompts.ts 40.00% 24 Missing ⚠️
src/core/templates.ts 51.21% 20 Missing ⚠️
src/commands/network.ts 78.78% 6 Missing and 1 partial ⚠️
src/commands/node/tasks.ts 66.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   87.09%   86.16%   -0.93%     
==========================================
  Files          40       43       +3     
  Lines       12545    13538     +993     
  Branches      944     1293     +349     
==========================================
+ Hits        10926    11665     +739     
- Misses       1568     1766     +198     
- Partials       51      107      +56     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.53% <100.00%> (+0.04%) ⬆️
src/commands/node/configs.ts 95.48% <100.00%> (+0.03%) ⬆️
src/commands/node/flags.ts 100.00% <100.00%> (ø)
src/commands/node/handlers.ts 100.00% <100.00%> (+3.96%) ⬆️
src/commands/node/index.ts 35.34% <100.00%> (-7.29%) ⬇️
src/core/enumerations.ts 100.00% <100.00%> (ø)
src/core/index.ts 100.00% <100.00%> (ø)
src/commands/network.ts 76.47% <78.78%> (+0.04%) ⬆️
src/commands/node/tasks.ts 94.31% <66.66%> (-0.29%) ⬇️
src/core/templates.ts 79.82% <51.21%> (-6.45%) ⬇️
... and 2 more

... and 21 files with indirect coverage changes

Impacted file tree graph