Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split node.test.mjs into multiple tests to increase pipeline stability #297

Merged
merged 3 commits into from
May 14, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • split test/e2e/commands/node.test.mjs to decrease run times and failure rates and increase pipeline stability
    • test/e2e/commands/node_pem_stop_add.test.mjs
    • test/e2e/commands/node_pfx_kill_add.test.mjs

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this May 13, 2024
@jeromy-cannon jeromy-cannon force-pushed the 00296-split-e2e-node-test branch from b1b817a to 182f4de Compare May 13, 2024 13:37
Signed-off-by: Jeromy Cannon <[email protected]>
Copy link
Contributor

github-actions bot commented May 13, 2024

Unit Test Results - Linux

  1 files  ±0   18 suites  ±0   1m 20s ⏱️ -1s
118 tests ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f5b4118. ± Comparison against base commit 5dbc60b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

Unit Test Results - Windows

  1 files  ±0   18 suites  ±0   1m 38s ⏱️ +3s
118 tests ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f5b4118. ± Comparison against base commit 5dbc60b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

E2E Relay Tests Coverage Report

1 files  ±0  1 suites  ±0   2m 15s ⏱️ +7s
5 tests ±0  5 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f5b4118. ± Comparison against base commit 5dbc60b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

E2E Mirror Node Tests Coverage Report

7 tests  ±0   7 ✅ ±0   5m 38s ⏱️ + 1m 59s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f5b4118. ± Comparison against base commit 5dbc60b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

E2E Node PEM Stop Add Tests Coverage Report

 1 files   1 suites   6m 44s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit f5b4118.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

E2E Tests Coverage Report

55 tests  ±0   55 ✅ ±0   3m 5s ⏱️ - 1m 6s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f5b4118. ± Comparison against base commit 5dbc60b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

E2E Node PFX Kill Add Tests Coverage Report

 1 files   1 suites   6m 1s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit f5b4118.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.26% (target: -1.00%) 87.74%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5dbc60b) 3169 2578 81.35%
Head commit (f5b4118) 3328 (+159) 2716 (+138) 81.61% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#297) 155 136 87.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 86.98225% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 81.42%. Comparing base (5dbc60b) to head (f5b4118).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   81.23%   81.42%   +0.19%     
==========================================
  Files          33       34       +1     
  Lines        3767     3936     +169     
  Branches      683      694      +11     
==========================================
+ Hits         3060     3205     +145     
- Misses        707      731      +24     
Files Coverage Δ
test/e2e/e2e_node_util.js 86.98% <86.98%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review May 13, 2024 15:12
@jeromy-cannon jeromy-cannon requested review from a team and leninmehedy as code owners May 13, 2024 15:12
@jeromy-cannon jeromy-cannon merged commit f9ace1e into main May 14, 2024
45 checks passed
@jeromy-cannon jeromy-cannon deleted the 00296-split-e2e-node-test branch May 14, 2024 17:31
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split node.test.mjs to increase speed and reduce failure rate in pipeline
4 participants