Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add k8.PodRef class and implement it across the codebase #1290

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • created PodRef class
  • use PodRef class across codebase

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Results - Windows

  1 files  ±0   60 suites  ±0   9s ⏱️ ±0s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bd54276. ± Comparison against base commit df2d9f8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Results - Linux

  1 files  ±0   60 suites  ±0   3s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bd54276. ± Comparison against base commit df2d9f8.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon changed the title 001253 k8 podref refactor: add k8.PodRef class and implement it across the codebase Feb 4, 2025
@jeromy-cannon jeromy-cannon force-pushed the 001253-k8-podref branch 2 times, most recently from be9e5e9 to 4f0eb05 Compare February 5, 2025 01:08
Base automatically changed from 001252-k8-podName to main February 5, 2025 11:27
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 5, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 26m 51s ⏱️ +2s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bd54276. ± Comparison against base commit df2d9f8.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+9.59% (target: -1.00%) 81.91%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (df2d9f8) 20599 14687 71.30%
Head commit (bd54276) 21169 (+570) 17124 (+2437) 80.89% (+9.59%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1290) 282 231 81.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 86.17021% with 39 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (df2d9f8) to head (bd54276).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/kube/k8_client.ts 80.51% 15 Missing ⚠️
src/core/kube/pod_ref.ts 76.47% 10 Missing and 2 partials ⚠️
src/commands/node/tasks.ts 94.11% 4 Missing ⚠️
src/core/kube/kube_errors.ts 86.66% 4 Missing ⚠️
src/core/platform_installer.ts 85.71% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1290    +/-   ##
========================================
  Coverage   81.70%   81.71%            
========================================
  Files          84       85     +1     
  Lines       21076    21169    +93     
  Branches     1432     1986   +554     
========================================
+ Hits        17221    17299    +78     
+ Misses       3814     3733    -81     
- Partials       41      137    +96     
Files with missing lines Coverage Δ
src/commands/mirror_node.ts 74.79% <100.00%> (+0.08%) ⬆️
src/commands/node/configs.ts 92.27% <100.00%> (-0.08%) ⬇️
src/commands/node/helper.ts 100.00% <100.00%> (ø)
src/core/account_manager.ts 84.76% <100.00%> (+0.11%) ⬆️
src/commands/node/tasks.ts 92.35% <94.11%> (-0.08%) ⬇️
src/core/kube/kube_errors.ts 93.93% <86.66%> (-0.51%) ⬇️
src/core/platform_installer.ts 87.14% <85.71%> (-0.58%) ⬇️
src/core/kube/pod_ref.ts 76.47% <76.47%> (ø)
src/core/kube/k8_client.ts 81.60% <80.51%> (+0.07%) ⬆️

... and 28 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 5, 2025 12:23
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners February 5, 2025 12:23
@jeromy-cannon jeromy-cannon added the PR: Needs Approval A pull request that needs reviews and approvals. label Feb 5, 2025
@jeromy-cannon jeromy-cannon merged commit 620e2f4 into main Feb 5, 2025
42 of 43 checks passed
@jeromy-cannon jeromy-cannon deleted the 001253-k8-podref branch February 5, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Approval A pull request that needs reviews and approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create PodRef class and integrate
2 participants