Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: created kube/PodName class and integrated into codebase #1288

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • created kube/PodName class
  • integrated kube/PodName
  • added PodNameInvalidError

Related Issues

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Results - Linux

  1 files  ±0   60 suites  ±0   5s ⏱️ +3s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e9f0af. ± Comparison against base commit 33dc849.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon changed the title 001252 k8 pod name refactor: created kube/PodName class and integrated into codebase Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Results - Windows

  1 files  ±0   60 suites  ±0   10s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
241 runs  ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e9f0af. ± Comparison against base commit 33dc849.

♻️ This comment has been updated with latest results.

Base automatically changed from 001252-k8-podname-pre1 to main February 5, 2025 01:09
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon self-assigned this Feb 5, 2025
@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 5, 2025 11:05
@jeromy-cannon jeromy-cannon requested review from a team and leninmehedy as code owners February 5, 2025 11:05
@jeromy-cannon jeromy-cannon added the PR: Needs Approval A pull request that needs reviews and approvals. label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 26m 42s ⏱️ +33s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e9f0af. ± Comparison against base commit 33dc849.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 26m 42s ⏱️ +33s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e9f0af. ± Comparison against base commit 33dc849.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 88.97059% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (33dc849) to head (5e9f0af).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/kube/pod_name.ts 88.00% 9 Missing ⚠️
src/commands/node/tasks.ts 50.00% 2 Missing ⚠️
src/core/kube/kube_errors.ts 89.47% 2 Missing ⚠️
src/core/templates.ts 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   81.66%   81.69%   +0.02%     
==========================================
  Files          82       83       +1     
  Lines       20948    21040      +92     
  Branches     1961     1570     -391     
==========================================
+ Hits        17108    17189      +81     
- Misses       3682     3771      +89     
+ Partials      158       80      -78     
Files with missing lines Coverage Δ
src/commands/mirror_node.ts 74.70% <100.00%> (+0.04%) ⬆️
src/commands/node/configs.ts 92.35% <100.00%> (+0.01%) ⬆️
src/core/account_manager.ts 84.64% <100.00%> (+0.01%) ⬆️
src/core/kube/k8_client.ts 81.62% <100.00%> (+0.01%) ⬆️
src/core/network_node_services.ts 100.00% <100.00%> (ø)
src/core/platform_installer.ts 87.71% <100.00%> (+0.03%) ⬆️
src/commands/node/tasks.ts 92.25% <50.00%> (-0.03%) ⬇️
src/core/kube/kube_errors.ts 94.44% <89.47%> (-5.56%) ⬇️
src/core/templates.ts 76.66% <60.00%> (+0.09%) ⬆️
src/core/kube/pod_name.ts 88.00% <88.00%> (ø)

... and 24 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit df2d9f8 into main Feb 5, 2025
43 checks passed
@jeromy-cannon jeromy-cannon deleted the 001252-k8-podName branch February 5, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Approval A pull request that needs reviews and approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create PodName class and integrate
2 participants