feat: Add adminKey flag to node setup command

[Ivo-Yankov]

Description

Related Issues

• Closes add flags to supply keys to use for node admin keys when creating genesis-network.json file #1042

[github-actions]

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   4s ⏱️ ±0s
236 tests +3  236 ✅ +3  0 💤 ±0  0 ❌ ±0 
241 runs  +3  241 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 3791c3a. ± Comparison against base commit 89c557a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   17s ⏱️ +5s
236 tests +3  236 ✅ +3  0 💤 ±0  0 ❌ ±0 
241 runs  +3  241 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 3791c3a. ± Comparison against base commit 89c557a.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 25m 37s ⏱️ - 2m 8s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
269 runs  ±0  269 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1afa97f. ± Comparison against base commit 89c557a.

[github-actions]

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 30m 8s ⏱️ + 2m 23s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
269 runs  ±0  269 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3791c3a. ± Comparison against base commit 89c557a.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

mirror node deploy should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand mirror node deploy should success

mirror node and explorer deploy should success ‑ E2E Test Suite for 'mirror-cmd-e2e' mirror-cmd-e2e MirrorNodeCommand mirror node and explorer deploy should success

♻️ This comment has been updated with latest results.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.24% (target: -1.00%)	✅ 39.58%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (89c557a)	21412	17873	83.47%
Head commit (3791c3a)	21941 (+529)	18368 (+495)	83.72% (+0.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1193)	48	19	39.58%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[codecov]

Codecov Report

Attention: Patch coverage is 39.58333% with 29 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (89c557a) to head (3791c3a).
Report is 136 commits behind head on main.

Files with missing lines	Patch %	Lines
...network_models/genesis_network_data_constructor.ts	9.67%	28 Missing ⚠️
src/commands/node/tasks.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   82.66%   82.81%   +0.14%     
==========================================
  Files          77       79       +2     
  Lines       21440    21941     +501     
  Branches     1914     1465     -449     
==========================================
+ Hits        17724    18171     +447     
- Misses       3593     3696     +103     
+ Partials      123       74      -49     

Files with missing lines	Coverage Δ
src/commands/flags.ts	76.60% <100.00%> (+1.14%)	⬆️
src/commands/node/configs.ts	92.51% <100.00%> (+0.01%)	⬆️
src/commands/node/flags.ts	100.00% <100.00%> (ø)
src/commands/node/tasks.ts	92.30% <50.00%> (-0.14%)	⬇️
...network_models/genesis_network_data_constructor.ts	23.07% <9.67%> (-3.65%)	⬇️

... and 36 files with indirect coverage changes

[jeromy-cannon]

@Ivo-Yankov ,

A few questions/thoughts:

1. As someone using Solo, how do I provide a different key for each node? When looking at the code I see that you allow a comma separated list of keys. However, when looking at the flags.ts code, I only see the description: Admin key. I think we need to provide a better description and provide a usage example.
2. Since we don't sign anything, I think it would be more friendly to just supply the public key. It will be smaller, easier to supply on the command line, and will be safer, since the private key isn't really needed here.
3. rename the flag from --admin-key to --admin-public-keys

[Ivo-Yankov]

A few questions/thoughts:

1. As someone using Solo, how do I provide a different key for each node? When looking at the code I see that you allow a comma separated list of keys. However, when looking at the flags.ts code, I only see the description: Admin key. I think we need to provide a better description and provide a usage example.
2. Since we don't sign anything, I think it would be more friendly to just supply the public key. It will be smaller, easier to supply on the command line, and will be safer, since the private key isn't really needed here.
3. rename the flag from --admin-key to --admin-public-keys

@jeromy-cannon I addressed points 2 and 3 and I think that mostly covers point 1. But I'm not sure on what is the appropriate way to provide a usage example.

[swirlds-automation]

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀