-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use "double fork" to invoke port forward within Taskfile #1148
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Reference from GeminiThe Problem: Process Groups and Signal Propagation The core issue is very likely related to process groups and how signals are propagated within them. Even with setsid (which creates a new session), if the kubectl port-forward process isn't properly placed in its own process group, Taskfile (or its parent process) might be sending signals that inadvertently terminate the kubectl process when a connection is established and then closed. Here's why this happens: Process Groups: Processes are organized into process groups. When a signal is sent to a process group, all processes within that group receive the signal. Taskfile's Process Management: Taskfile, when it finishes executing a task, might be sending signals (like SIGHUP or SIGTERM) to its child processes and their process groups. Connection Establishment and Closure: When you connect with nc, the following happens: nc connects to the forwarded port. The Solution: Explicit Process Group Management The most reliable solution is to explicitly create a new process group for the kubectl port-forward process. This ensures that signals sent by Taskfile won't affect it |
…portforward-quit-task Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # Taskfile.helper.yml
@JeffreyDallas , I already fixed this: #1132 |
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
E2E Test Report 17 files 126 suites 1h 26m 47s ⏱️ Results for commit f7dc8ca. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
- Coverage 83.37% 82.97% -0.40%
==========================================
Files 77 77
Lines 20809 21171 +362
Branches 1717 1468 -249
==========================================
+ Hits 17349 17567 +218
- Misses 3363 3544 +181
+ Partials 97 60 -37
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should support -q/--quiet on all commands/subcommands. Instead of removing the flag, just add the flag to the destroy subcommands.
Signed-off-by: Jeffrey Tang <[email protected]>
## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f))
🎉 This PR is included in version 0.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
commit b871e44 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:30:01 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit cb91806 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:17:17 2025 +0000 fix: fixed merge issue with incorrect license header (#1235) Signed-off-by: Jeromy Cannon <[email protected]> commit 6f43952 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:04:39 2025 +0000 refactor: minor refactors to K8 setting private and public modifiers (#1234) Signed-off-by: Jeromy Cannon <[email protected]> commit 9c31b6c Author: Jeromy Cannon <[email protected]> Date: Wed Jan 29 23:27:15 2025 +0000 chore: changed license header to SPDX and ran npm run format (#1233) Signed-off-by: Jeromy Cannon <[email protected]> commit b044fcc Author: Ivo Yankov <[email protected]> Date: Wed Jan 29 22:26:19 2025 +0200 feat: Add adminKey flag to node setup command (#1193) Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 0c4fec2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:58:40 2025 -0600 chore(deps): bump @inquirer/prompts from 7.2.3 to 7.2.4 (#1228) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18a07b8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:57:37 2025 -0600 chore(deps): bump actions/setup-java from 4.6.0 to 4.7.0 (#1229) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71e56a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 15:21:42 2025 -0600 chore(deps-dev): bump typescript-eslint from 8.21.0 to 8.22.0 (#1223) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c5212a Author: Jan Milenkov <[email protected]> Date: Tue Jan 28 16:44:28 2025 +0200 chore(lint): manually fixed imports to be consisent (#1219) Signed-off-by: instamenta <[email protected]> commit d460985 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:41:01 2025 -0600 chore(deps-dev): bump @types/node from 22.10.10 to 22.12.0 (#1222) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c448060 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:39:44 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.21.0 to 8.22.0 (#1221) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83ad04f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 14:54:56 2025 -0600 chore(deps-dev): bump remark-lint-unordered-list-marker-style from 4.0.0 to 4.0.1 (#1214) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d9a3592 Author: JeffreyDallas <[email protected]> Date: Mon Jan 27 13:23:37 2025 -0600 feat: update solo to support pathPrefix of mirror node importer (#1204) Signed-off-by: Jeffrey Tang <[email protected]> commit 6773955 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:57:49 2025 -0600 chore(deps-dev): bump remark-lint-list-item-indent from 4.0.0 to 4.0.1 (#1210) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a31498e Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 20:06:08 2025 +0200 feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed (#1208) Signed-off-by: instamenta <[email protected]> commit fb69435 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:53 2025 -0600 chore(deps-dev): bump remark-preset-lint-consistent from 6.0.0 to 6.0.1 (#1213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ab36894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:02 2025 -0600 chore(deps-dev): bump eslint from 9.18.0 to 9.19.0 (#1215) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 764db3a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:26:12 2025 -0600 chore(deps-dev): bump remark-preset-lint-recommended from 7.0.0 to 7.0.1 (#1212) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18ee776 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:25:12 2025 -0600 chore(deps-dev): bump @eslint/js from 9.18.0 to 9.19.0 (#1211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 809d0ab Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 17:14:36 2025 +0200 feat(remote-config): save reusable solo flags in remoteconfig (#1191) Signed-off-by: instamenta <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 7877d92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:03:45 2025 -0600 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 (#1209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4ab4dd5 Author: Jan Milenkov <[email protected]> Date: Fri Jan 24 18:46:00 2025 +0200 feat(cli): reduce redundancy on context to cluster flags in command `deployment create` (#1156) Signed-off-by: instamenta <[email protected]> commit 80176a3 Author: Hedera Eng Automation <[email protected]> Date: Fri Jan 24 15:39:32 2025 +0000 chore(release): 0.34.0 [skip ci] ## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f)) commit d0a8046 Author: Swirlds Automation <[email protected]> Date: Fri Jan 24 15:37:52 2025 +0000 chore: auto update docs/content/User/StepByStepGuide.md Signed-off-by: Swirlds Automation <[email protected]> commit d60247a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:30:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.9 to 22.10.10 (#1207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 28fd81e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:29:42 2025 -0600 chore(deps-dev): bump @types/ws from 8.5.13 to 8.5.14 (#1206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 64fbf95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 11:40:40 2025 -0600 chore(deps-dev): bump mocha from 11.0.1 to 11.1.0 (#1200) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 960db04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 08:19:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.7 to 22.10.9 (#1199) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d1a8cb Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 13:28:24 2025 -0600 fix: merge error due to change of remote_config_tasks (#1197) Signed-off-by: Jeffrey Tang <[email protected]> commit 66cfc4d Author: Ivo Yankov <[email protected]> Date: Wed Jan 22 18:38:35 2025 +0200 fix: Refactor RemoteConfigTasks class (#1185) Signed-off-by: Ivo Yankov <[email protected]> commit 0887fa6 Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 10:38:00 2025 -0600 feat: separate explorer from mirror node install/uninstall (#1177) Signed-off-by: Jeffrey Tang <[email protected]> commit 89c557a Author: Ivo Yankov <[email protected]> Date: Tue Jan 21 16:40:39 2025 +0200 fix: remove k8.getKubeConfig (#1182) Signed-off-by: Ivo Yankov <[email protected]> commit 0c415ef Author: Nathan Klick <[email protected]> Date: Tue Jan 21 07:55:33 2025 -0600 fix: update hedera explorer chart version and location (#1188) Signed-off-by: Nathan Klick <[email protected]> commit 0e236d7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 21 07:27:00 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.20.0 to 8.21.0 (#1190) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]>
commit b871e44 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:30:01 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit cb91806 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:17:17 2025 +0000 fix: fixed merge issue with incorrect license header (#1235) Signed-off-by: Jeromy Cannon <[email protected]> commit 6f43952 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:04:39 2025 +0000 refactor: minor refactors to K8 setting private and public modifiers (#1234) Signed-off-by: Jeromy Cannon <[email protected]> commit 9c31b6c Author: Jeromy Cannon <[email protected]> Date: Wed Jan 29 23:27:15 2025 +0000 chore: changed license header to SPDX and ran npm run format (#1233) Signed-off-by: Jeromy Cannon <[email protected]> commit b044fcc Author: Ivo Yankov <[email protected]> Date: Wed Jan 29 22:26:19 2025 +0200 feat: Add adminKey flag to node setup command (#1193) Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 0c4fec2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:58:40 2025 -0600 chore(deps): bump @inquirer/prompts from 7.2.3 to 7.2.4 (#1228) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18a07b8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:57:37 2025 -0600 chore(deps): bump actions/setup-java from 4.6.0 to 4.7.0 (#1229) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71e56a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 15:21:42 2025 -0600 chore(deps-dev): bump typescript-eslint from 8.21.0 to 8.22.0 (#1223) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c5212a Author: Jan Milenkov <[email protected]> Date: Tue Jan 28 16:44:28 2025 +0200 chore(lint): manually fixed imports to be consisent (#1219) Signed-off-by: instamenta <[email protected]> commit d460985 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:41:01 2025 -0600 chore(deps-dev): bump @types/node from 22.10.10 to 22.12.0 (#1222) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c448060 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:39:44 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.21.0 to 8.22.0 (#1221) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83ad04f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 14:54:56 2025 -0600 chore(deps-dev): bump remark-lint-unordered-list-marker-style from 4.0.0 to 4.0.1 (#1214) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d9a3592 Author: JeffreyDallas <[email protected]> Date: Mon Jan 27 13:23:37 2025 -0600 feat: update solo to support pathPrefix of mirror node importer (#1204) Signed-off-by: Jeffrey Tang <[email protected]> commit 6773955 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:57:49 2025 -0600 chore(deps-dev): bump remark-lint-list-item-indent from 4.0.0 to 4.0.1 (#1210) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a31498e Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 20:06:08 2025 +0200 feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed (#1208) Signed-off-by: instamenta <[email protected]> commit fb69435 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:53 2025 -0600 chore(deps-dev): bump remark-preset-lint-consistent from 6.0.0 to 6.0.1 (#1213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ab36894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:02 2025 -0600 chore(deps-dev): bump eslint from 9.18.0 to 9.19.0 (#1215) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 764db3a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:26:12 2025 -0600 chore(deps-dev): bump remark-preset-lint-recommended from 7.0.0 to 7.0.1 (#1212) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18ee776 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:25:12 2025 -0600 chore(deps-dev): bump @eslint/js from 9.18.0 to 9.19.0 (#1211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 809d0ab Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 17:14:36 2025 +0200 feat(remote-config): save reusable solo flags in remoteconfig (#1191) Signed-off-by: instamenta <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 7877d92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:03:45 2025 -0600 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 (#1209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4ab4dd5 Author: Jan Milenkov <[email protected]> Date: Fri Jan 24 18:46:00 2025 +0200 feat(cli): reduce redundancy on context to cluster flags in command `deployment create` (#1156) Signed-off-by: instamenta <[email protected]> commit 80176a3 Author: Hedera Eng Automation <[email protected]> Date: Fri Jan 24 15:39:32 2025 +0000 chore(release): 0.34.0 [skip ci] ## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f)) commit d0a8046 Author: Swirlds Automation <[email protected]> Date: Fri Jan 24 15:37:52 2025 +0000 chore: auto update docs/content/User/StepByStepGuide.md Signed-off-by: Swirlds Automation <[email protected]> commit d60247a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:30:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.9 to 22.10.10 (#1207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 28fd81e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:29:42 2025 -0600 chore(deps-dev): bump @types/ws from 8.5.13 to 8.5.14 (#1206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 64fbf95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 11:40:40 2025 -0600 chore(deps-dev): bump mocha from 11.0.1 to 11.1.0 (#1200) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 960db04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 08:19:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.7 to 22.10.9 (#1199) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d1a8cb Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 13:28:24 2025 -0600 fix: merge error due to change of remote_config_tasks (#1197) Signed-off-by: Jeffrey Tang <[email protected]> commit 66cfc4d Author: Ivo Yankov <[email protected]> Date: Wed Jan 22 18:38:35 2025 +0200 fix: Refactor RemoteConfigTasks class (#1185) Signed-off-by: Ivo Yankov <[email protected]> commit 0887fa6 Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 10:38:00 2025 -0600 feat: separate explorer from mirror node install/uninstall (#1177) Signed-off-by: Jeffrey Tang <[email protected]> commit 89c557a Author: Ivo Yankov <[email protected]> Date: Tue Jan 21 16:40:39 2025 +0200 fix: remove k8.getKubeConfig (#1182) Signed-off-by: Ivo Yankov <[email protected]> commit 0c415ef Author: Nathan Klick <[email protected]> Date: Tue Jan 21 07:55:33 2025 -0600 fix: update hedera explorer chart version and location (#1188) Signed-off-by: Nathan Klick <[email protected]> commit 0e236d7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 21 07:27:00 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.20.0 to 8.21.0 (#1190) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]>
commit 8d614c6 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:42:17 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit 28a4a9f Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:33:00 2025 +0000 Squashed commit of the following: commit b871e44 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:30:01 2025 +0000 rename testClusterConnection to testContextConnection Signed-off-by: Jeromy Cannon <[email protected]> commit cb91806 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:17:17 2025 +0000 fix: fixed merge issue with incorrect license header (#1235) Signed-off-by: Jeromy Cannon <[email protected]> commit 6f43952 Author: Jeromy Cannon <[email protected]> Date: Thu Jan 30 09:04:39 2025 +0000 refactor: minor refactors to K8 setting private and public modifiers (#1234) Signed-off-by: Jeromy Cannon <[email protected]> commit 9c31b6c Author: Jeromy Cannon <[email protected]> Date: Wed Jan 29 23:27:15 2025 +0000 chore: changed license header to SPDX and ran npm run format (#1233) Signed-off-by: Jeromy Cannon <[email protected]> commit b044fcc Author: Ivo Yankov <[email protected]> Date: Wed Jan 29 22:26:19 2025 +0200 feat: Add adminKey flag to node setup command (#1193) Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 0c4fec2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:58:40 2025 -0600 chore(deps): bump @inquirer/prompts from 7.2.3 to 7.2.4 (#1228) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18a07b8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jan 29 13:57:37 2025 -0600 chore(deps): bump actions/setup-java from 4.6.0 to 4.7.0 (#1229) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 71e56a9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 15:21:42 2025 -0600 chore(deps-dev): bump typescript-eslint from 8.21.0 to 8.22.0 (#1223) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1c5212a Author: Jan Milenkov <[email protected]> Date: Tue Jan 28 16:44:28 2025 +0200 chore(lint): manually fixed imports to be consisent (#1219) Signed-off-by: instamenta <[email protected]> commit d460985 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:41:01 2025 -0600 chore(deps-dev): bump @types/node from 22.10.10 to 22.12.0 (#1222) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c448060 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 28 08:39:44 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.21.0 to 8.22.0 (#1221) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83ad04f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 14:54:56 2025 -0600 chore(deps-dev): bump remark-lint-unordered-list-marker-style from 4.0.0 to 4.0.1 (#1214) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d9a3592 Author: JeffreyDallas <[email protected]> Date: Mon Jan 27 13:23:37 2025 -0600 feat: update solo to support pathPrefix of mirror node importer (#1204) Signed-off-by: Jeffrey Tang <[email protected]> commit 6773955 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:57:49 2025 -0600 chore(deps-dev): bump remark-lint-list-item-indent from 4.0.0 to 4.0.1 (#1210) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a31498e Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 20:06:08 2025 +0200 feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed (#1208) Signed-off-by: instamenta <[email protected]> commit fb69435 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:53 2025 -0600 chore(deps-dev): bump remark-preset-lint-consistent from 6.0.0 to 6.0.1 (#1213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ab36894 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 12:00:02 2025 -0600 chore(deps-dev): bump eslint from 9.18.0 to 9.19.0 (#1215) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 764db3a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:26:12 2025 -0600 chore(deps-dev): bump remark-preset-lint-recommended from 7.0.0 to 7.0.1 (#1212) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 18ee776 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:25:12 2025 -0600 chore(deps-dev): bump @eslint/js from 9.18.0 to 9.19.0 (#1211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 809d0ab Author: Jan Milenkov <[email protected]> Date: Mon Jan 27 17:14:36 2025 +0200 feat(remote-config): save reusable solo flags in remoteconfig (#1191) Signed-off-by: instamenta <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 7877d92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 27 09:03:45 2025 -0600 chore(deps): bump actions/setup-node from 4.1.0 to 4.2.0 (#1209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4ab4dd5 Author: Jan Milenkov <[email protected]> Date: Fri Jan 24 18:46:00 2025 +0200 feat(cli): reduce redundancy on context to cluster flags in command `deployment create` (#1156) Signed-off-by: instamenta <[email protected]> commit 80176a3 Author: Hedera Eng Automation <[email protected]> Date: Fri Jan 24 15:39:32 2025 +0000 chore(release): 0.34.0 [skip ci] ## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f)) commit d0a8046 Author: Swirlds Automation <[email protected]> Date: Fri Jan 24 15:37:52 2025 +0000 chore: auto update docs/content/User/StepByStepGuide.md Signed-off-by: Swirlds Automation <[email protected]> commit d60247a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:30:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.9 to 22.10.10 (#1207) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 28fd81e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Jan 24 08:29:42 2025 -0600 chore(deps-dev): bump @types/ws from 8.5.13 to 8.5.14 (#1206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 64fbf95 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 11:40:40 2025 -0600 chore(deps-dev): bump mocha from 11.0.1 to 11.1.0 (#1200) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 960db04 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 23 08:19:52 2025 -0600 chore(deps-dev): bump @types/node from 22.10.7 to 22.10.9 (#1199) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9d1a8cb Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 13:28:24 2025 -0600 fix: merge error due to change of remote_config_tasks (#1197) Signed-off-by: Jeffrey Tang <[email protected]> commit 66cfc4d Author: Ivo Yankov <[email protected]> Date: Wed Jan 22 18:38:35 2025 +0200 fix: Refactor RemoteConfigTasks class (#1185) Signed-off-by: Ivo Yankov <[email protected]> commit 0887fa6 Author: JeffreyDallas <[email protected]> Date: Wed Jan 22 10:38:00 2025 -0600 feat: separate explorer from mirror node install/uninstall (#1177) Signed-off-by: Jeffrey Tang <[email protected]> commit 89c557a Author: Ivo Yankov <[email protected]> Date: Tue Jan 21 16:40:39 2025 +0200 fix: remove k8.getKubeConfig (#1182) Signed-off-by: Ivo Yankov <[email protected]> commit 0c415ef Author: Nathan Klick <[email protected]> Date: Tue Jan 21 07:55:33 2025 -0600 fix: update hedera explorer chart version and location (#1188) Signed-off-by: Nathan Klick <[email protected]> commit 0e236d7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jan 21 07:27:00 2025 -0600 chore(deps-dev): bump @typescript-eslint/utils from 8.20.0 to 8.21.0 (#1190) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>
Description
This pull request changes the following:
Related Issues