Csv import fixes #1584
Merged
Csv import fixes #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
Signed-off-by: John Bair <[email protected]>
jbair06
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 161 161
Lines 6148 6148
Branches 1138 1146 +8
=======================================
Hits 6093 6093
+ Misses 55 52 -3
- Partials 0 3 +3 see 3 files with indirect coverage changes |
Svetoslavb04
approved these changes
Feb 27, 2025
SvetBorislavov
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current templates in use for CSV importing were slightly different than those provided originally. As such, this PR adds the new features of the templates, in addition to fixing some visually issues when displaying the transfer data.
Related issue(s):
Fixes #1571, #1569