Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTS NFTs as if they're deployed ERC721/IERC721Metadata/IERC721Enumerable contracts #82

Merged
merged 26 commits into from
Oct 7, 2022

Conversation

natanasow
Copy link
Contributor

Signed-off-by: nikolay [email protected]

Description:

Related issue(s):

Fixes #79

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested review from Nana-EC and shemnon October 5, 2022 09:26
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
@Nana-EC Nana-EC requested a review from lukelee-sl October 5, 2022 21:20
Nana-EC
Nana-EC previously approved these changes Oct 5, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

expect(isApprovedForAllAfter).to.equal(true);
});

it("should be able to execute transferFrom", async function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it("should be able to execute transferFrom", async function () {
it("should be able to execute delegate transferFrom", async function () {

expect(ownerAfter).to.equal(secondWallet.address);
});

it("should be able to approve", async function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it("should be able to approve", async function () {
it("should be able to delegate approve", async function () {

Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natanasow natanasow merged commit 30404a3 into main Oct 7, 2022
@natanasow natanasow deleted the 79-use-hts-nfts-as-if-they-are-deployed-erc721 branch October 7, 2022 11:11
@Nana-EC Nana-EC added this to the 0.2.0 milestone Oct 11, 2022
@Nana-EC Nana-EC added the enhancement New feature or request label Oct 12, 2022
georg-getz pushed a commit to georg-getz/hedera-smart-contracts that referenced this pull request Dec 12, 2022
…merable contracts (hashgraph#82)

* Add tests

Signed-off-by: nikolay <[email protected]>

* Install @openzeppelin/contracts

Signed-off-by: nikolay <[email protected]>

* Edit tests

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Bump hedera local node version

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Fix typos

Signed-off-by: nikolay <[email protected]>

* Edit workflow

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Edit ci

Signed-off-by: nikolay <[email protected]>

* Add tmate for debugging

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

* Test ci

Signed-off-by: nikolay <[email protected]>

Signed-off-by: nikolay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-218: Use HTS NFTs as if they're deployed ERC721/IERC721Metadata/IERC721Enumerable contracts
3 participants