update types for maxSupply to int64 and initialSupply to uint64 #59
Conversation
Signed-off-by: lukelee-sl <[email protected]>
…rvice and services code Signed-off-by: lukelee-sl <[email protected]>
| @@ -395,7 +395,7 @@ interface IHederaTokenService { | |||
| /// @return tokenAddress the created token's address | |||
| function createFungibleToken( | |||
| HederaToken memory token, | |||
| uint initialTotalSupply, | |||
| uint64 initialTotalSupply, | |||
| uint decimals | |||
There was a problem hiding this comment.
decimals is uint32 - https://github.com/hashgraph/hedera-protobufs/blob/d5eaa07c41999fe8e6611b552d50373f8a809a07/services/token_create.proto#L92
How far the rabbit hole do we go?
There was a problem hiding this comment.
It makes sense to me to fix it all while I'm here. There should be no difference in the services code except the hash that is generated.
There was a problem hiding this comment.
Alongside the hash update in services, I think we can also delete the initSupply and decimals checks in TokenCreatePrecompile, since they will no longer be needed after this type fix.
There was a problem hiding this comment.
@dimitar-dinev I believe we might want to keep the checks as the we will still be supporting the old version of these types.
Signed-off-by: lukelee-sl <[email protected]>
Nana-EC
added
enhancement
…graph#59) * update types for maxSupply to int64 and initialSupply to uint64 Signed-off-by: lukelee-sl <[email protected]> * update approveNFT and getApproved to match signature in HederaTokenService and services code Signed-off-by: lukelee-sl <[email protected]> * update decimals to uint32 Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl [email protected]
Description:
Update the types for maxSupply and initialSupply to match the types in the protobuf specification.
Related issue(s):
Fixes #56
Notes for reviewer:
Checklist