Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return value to fungible allowance #36

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add return value to fungible allowance #36

merged 1 commit into from
Jul 15, 2022

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jul 14, 2022

Description:
The fungible allowance needs to return the number of tokens remaining.

Signed-off-by: Danno Ferrin [email protected]

Related issue(s):

for #6

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

The fungible allowance needs to return the number of tokens remaining.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon requested a review from Nana-EC July 14, 2022 22:43
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon shemnon merged commit 9fdcf53 into main Jul 15, 2022
@shemnon shemnon deleted the 6-update-allowance branch July 15, 2022 18:09
@Nana-EC Nana-EC added this to the 0.1.0 milestone Oct 11, 2022
@Nana-EC Nana-EC added the enhancement New feature or request label Oct 12, 2022
georg-getz pushed a commit to georg-getz/hedera-smart-contracts that referenced this pull request Dec 12, 2022
The fungible allowance needs to return the number of tokens remaining.

Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants