Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make HederaResponseCodes.sol up-to-date with the latest protobufs ones #1218

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Feb 3, 2025

Description:

Problem

There are missing response codes in HederaResponseCodes.sol.

Solution

Related issue(s):

Fixes #847

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow requested review from georgi-l95, Ivo-Yankov and a team as code owners February 3, 2025 14:36
@natanasow natanasow requested a review from bubo February 3, 2025 14:36
@natanasow natanasow self-assigned this Feb 3, 2025
@natanasow natanasow added the enhancement New feature or request label Feb 3, 2025
@natanasow natanasow added this to the 0.12.0 milestone Feb 3, 2025
@natanasow natanasow marked this pull request as draft February 3, 2025 14:37
Copy link

github-actions bot commented Feb 3, 2025

Test Results

 17 files  ± 0   91 suites   - 3   12m 37s ⏱️ -30s
292 tests  - 13  284 ✅  - 12  6 💤  - 3  2 ❌ +2 
313 runs   - 14  304 ✅  - 13  7 💤  - 3  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 106cc17. ± Comparison against base commit b332345.

This pull request removes 14 and adds 1 tests. Note that renamed tests count towards both.
should be able to associate() to the token from a contract ‑ @HRC-719 Test Suite HRC719 wrapper contract should be able to associate() to the token from a contract
should be able to associate() to the token from an EOA ‑ @HRC-719 Test Suite HRC719 Token should be able to associate() to the token from an EOA
should be able to call isAssociated() after token association ‑ @HRC-719 Test Suite HRC719 wrapper contract should be able to call isAssociated() after token association
should be able to call isAssociated() after token dissociation ‑ @HRC-719 Test Suite HRC719 wrapper contract should be able to call isAssociated() after token dissociation
should be able to call isAssociated() to the token from an EOA when associated ‑ @HRC-719 Test Suite HRC719 Token should be able to call isAssociated() to the token from an EOA when associated
should be able to call isAssociated() to the token from an EOA when dissociated ‑ @HRC-719 Test Suite HRC719 Token should be able to call isAssociated() to the token from an EOA when dissociated
should be able to call isAssociated() to the token from an EOA ‑ @HRC-719 Test Suite HRC719 Token should be able to call isAssociated() to the token from an EOA
should be able to call isAssociated() ‑ @HRC-719 Test Suite HRC719 wrapper contract should be able to call isAssociated()
should be able to dissociate() to the token from an EOA ‑ @HRC-719 Test Suite HRC719 Token should be able to dissociate() to the token from an EOA
should be able to disssociate() to the token from a contract ‑ @HRC-719 Test Suite HRC719 wrapper contract should be able to disssociate() to the token from a contract
…
"before all" hook in "@HRC-719 Test Suite" ‑ @HRC-719 Test Suite "before all" hook in "@HRC-719 Test Suite"

@natanasow natanasow marked this pull request as ready for review February 3, 2025 15:24
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow merged commit 6fa33ab into main Feb 3, 2025
35 of 41 checks passed
@natanasow natanasow deleted the 847-make-hedera-response-codes-up-to-date-with-the-latest-profobufs branch February 3, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HederaResponseCodes.sol up-to-date with the latest protobufs ones
2 participants