Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt PlatformTestingTool to work with Bytes for system transactions #17367

Merged

Conversation

IvanKavaldzhiev
Copy link
Collaborator

Description:
Enhance PlatformTestingTool to work with Bytes format for StateSignatureTransactions.

Related issue(s):

Fixes #17082

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…estingTool-to-work-with-bytes

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
@IvanKavaldzhiev IvanKavaldzhiev added the Platform Tickets pertaining to the platform label Jan 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev added this to the v0.59 milestone Jan 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Jan 14, 2025
@IvanKavaldzhiev IvanKavaldzhiev requested review from a team as code owners January 14, 2025 12:29
@IvanKavaldzhiev IvanKavaldzhiev marked this pull request as draft January 14, 2025 12:56
@IvanKavaldzhiev IvanKavaldzhiev marked this pull request as ready for review January 14, 2025 16:21
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve platform-sdk/platform-apps/tests/PlatformTestingTool/build.gradle.kts

Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.71% (target: -1.00%) 57.46%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6e5da9b) 96684 69457 71.84%
Head commit (f59f6c5) 96724 (+40) 70171 (+714) 72.55% (+0.71%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17367) 134 77 57.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 56.71642% with 58 lines in your changes missing coverage. Please review.

Project coverage is 68.60%. Comparing base (6e5da9b) to head (f59f6c5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...swirlds/demo/platform/PlatformTestingToolMain.java 44.23% 29 Missing ⚠️
.../com/swirlds/demo/platform/PttTransactionPool.java 0.00% 19 Missing ⚠️
...o/platform/PlatformTestingToolStateLifecycles.java 83.60% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17367      +/-   ##
============================================
+ Coverage     67.95%   68.60%   +0.65%     
- Complexity    22345    22477     +132     
============================================
  Files          2606     2606              
  Lines         96901    96941      +40     
  Branches      10098    10101       +3     
============================================
+ Hits          65850    66508     +658     
+ Misses        27292    26619     -673     
- Partials       3759     3814      +55     
Files with missing lines Coverage Δ
.../java/com/swirlds/demo/platform/PayloadConfig.java 84.94% <100.00%> (+33.33%) ⬆️
...o/platform/PlatformTestingToolStateLifecycles.java 33.45% <83.60%> (+33.45%) ⬆️
.../com/swirlds/demo/platform/PttTransactionPool.java 21.92% <0.00%> (+0.95%) ⬆️
...swirlds/demo/platform/PlatformTestingToolMain.java 40.90% <44.23%> (+40.90%) ⬆️

... and 23 files with indirect coverage changes

Impacted file tree graph

andrewb1269hg
andrewb1269hg previously approved these changes Jan 14, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve platform-sdk/platform-apps/tests/PlatformTestingTool/build.gradle.kts

…estingTool-to-work-with-bytes

# Conflicts:
#	platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
lpetrovic05
lpetrovic05 previously approved these changes Jan 15, 2025
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve build.gradle.kts

@IvanKavaldzhiev IvanKavaldzhiev merged commit 79f9327 into main Jan 16, 2025
44 of 46 checks passed
@IvanKavaldzhiev IvanKavaldzhiev deleted the 17082-adapt-PlatformTestingTool-to-work-with-bytes branch January 16, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt PlatformTestingTool to work with the Bytes format for system transactions
3 participants