Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PcesReadWriteTests.corruptedEventTest #17312

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

lpetrovic05
Copy link
Member

closes #17280

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 added this to the v0.59 milestone Jan 10, 2025
@lpetrovic05 lpetrovic05 self-assigned this Jan 10, 2025
@lpetrovic05 lpetrovic05 requested review from a team as code owners January 10, 2025 12:54
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (be1981d) to head (19a624e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17312      +/-   ##
============================================
- Coverage     67.41%   67.41%   -0.01%     
  Complexity    22063    22063              
============================================
  Files          2585     2585              
  Lines         96408    96410       +2     
  Branches      10071    10071              
============================================
+ Hits          64992    64993       +1     
+ Misses        27698    27697       -1     
- Partials       3718     3720       +2     
Files with missing lines Coverage Δ
.../platform/event/preconsensus/PcesFileIterator.java 91.11% <100.00%> (+0.41%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 87.88%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be1981d) 96191 68558 71.27%
Head commit (95edab4) 96203 (+12) 68565 (+7) 71.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17312) 33 29 87.88%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 merged commit 04f8074 into main Jan 13, 2025
46 of 47 checks passed
@lpetrovic05 lpetrovic05 deleted the 17280-M-fix-PcesReadWriteTests.corruptedEventTest branch January 13, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PcesReadWriteTests.corruptedEventTest failing on seed -5596113931140436367L
2 participants