-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restore ServicesMainTest.java #17262
Conversation
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
…-network # Conflicts: # hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/state/StateModule.java # hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/ServicesAppTest.java # hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/ServicesStateTest.java # platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoMain.java # platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoMain.java # platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoMain.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/PlatformBuilder.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/CryptoStatic.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/EnhancedKeyStoreLoader.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gui/SwirldsGui.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/network/connectivity/OutboundConnectionCreator.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/address/AddressBookNetworkUtils.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/crypto/CryptoArgsProvider.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/util/AddressBookNetworkUtilsTests.java
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
…-network # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/ServicesMain.java
Signed-off-by: Edward Wertz <[email protected]>
…twork # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
…twork # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/ServicesMain.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/Browser.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/config/PlatformConfigurationExtension.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17262 +/- ##
============================================
+ Coverage 67.24% 67.31% +0.06%
- Complexity 21991 22010 +19
============================================
Files 2583 2583
Lines 96307 96311 +4
Branches 10054 10054
============================================
+ Hits 64763 64832 +69
+ Misses 27839 27768 -71
- Partials 3705 3711 +6
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
Signed-off-by: Edward Wertz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for plowing through this @edward-swirldslabs!
Signed-off-by: Edward Wertz <[email protected]>
367ae25
Signed-off-by: Edward Wertz <[email protected]>
Fixes #17261
This PR restores the
ServicesMainTest.java
file with updated unit tests reflecting the new exit conditions for checking node ids provided by commandline or environment variable.