refactor: adapt AddressBookTestingTool to support transaction Bytes #17197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…sBookTestingTool-to-work-with-bytes # Conflicts: # platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…okTestingTool-to-work-with-bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…okTestingTool-to-work-with-bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17197 +/- ##
============================================
+ Coverage 67.41% 67.50% +0.09%
- Complexity 22097 22122 +25
============================================
Files 2588 2588
Lines 96626 96645 +19
Branches 10094 10096 +2
============================================
+ Hits 65139 65242 +103
+ Misses 27761 27666 -95
- Partials 3726 3737 +11
... and 1 file with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
andrewb1269hg
approved these changes
Jan 3, 2025
…okTestingTool-to-work-with-bytes
andrewb1269hg
previously approved these changes
Jan 6, 2025
mustafauzunn
reviewed
Jan 7, 2025
...kTestingTool/src/test/java/com/swirlds/demo/addressbook/AddressBookTestingToolStateTest.java
Outdated
Show resolved
Hide resolved
…okTestingTool-to-work-with-bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…okTestingTool-to-work-with-bytes
… before accepting it in callback Signed-off-by: Ivan Kavaldzhiev <[email protected]>
poulok
reviewed
Jan 7, 2025
...sBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
Outdated
Show resolved
Hide resolved
poulok
reviewed
Jan 7, 2025
...sBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
Outdated
Show resolved
Hide resolved
poulok
reviewed
Jan 7, 2025
...sBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
Outdated
Show resolved
Hide resolved
poulok
reviewed
Jan 7, 2025
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java
Outdated
Show resolved
Hide resolved
…okTestingTool-to-work-with-bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…okTestingTool-to-work-with-bytes
poulok
previously approved these changes
Jan 8, 2025
andrewb1269hg
previously approved these changes
Jan 9, 2025
…okTestingTool-to-work-with-bytes # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
IvanKavaldzhiev
dismissed stale reviews from andrewb1269hg and poulok
via
080b366
lpetrovic05
approved these changes
Jan 13, 2025
mustafauzunn
approved these changes
Jan 13, 2025
andrewb1269hg
approved these changes
Jan 13, 2025
IvanKavaldzhiev
deleted the
17081-adapt-AddressBookTestingTool-to-work-with-bytes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances AddressBookTestingTool to utilize Bytes representation of system transactions.
Related issue(s):
Fixes #17081
Notes for reviewer:
Checklist