Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create fake TSS library for testing #15908

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Oct 8, 2024

Description:

Related issue(s):

#15492

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Oct 8, 2024
@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.56 milestone Oct 8, 2024
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Copy link

codacy-production bot commented Oct 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (373935a) 99324 61206 61.62%
Head commit (6f17c87) 99443 (+119) 61206 (+0) 61.55% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15908) 119 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 119 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@373935a). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...dera/node/app/tss/api/TssParticipantDirectory.java 0.00% 77 Missing ⚠️
...hedera/node/app/tss/pairings/PairingSignature.java 0.00% 7 Missing ⚠️
...hedera/node/app/tss/pairings/FakeGroupElement.java 0.00% 6 Missing ⚠️
...a/com/hedera/node/app/tss/api/TssPrivateShare.java 0.00% 4 Missing ⚠️
...va/com/hedera/node/app/tss/api/TssPublicShare.java 0.00% 4 Missing ⚠️
...com/hedera/node/app/tss/api/TssShareSignature.java 0.00% 4 Missing ⚠️
...hedera/node/app/tss/pairings/FakeFieldElement.java 0.00% 4 Missing ⚠️
...edera/node/app/tss/pairings/PairingPrivateKey.java 0.00% 4 Missing ⚠️
...n/java/com/hedera/node/app/tss/api/TssMessage.java 0.00% 3 Missing ⚠️
...n/java/com/hedera/node/app/tss/api/TssShareId.java 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15908   +/-   ##
==========================================
  Coverage           ?   57.94%           
  Complexity         ?    19726           
==========================================
  Files              ?     2720           
  Lines              ?    99626           
  Branches           ?    10331           
==========================================
  Hits               ?    57724           
  Misses             ?    38283           
  Partials           ?     3619           
Files with missing lines Coverage Δ
...hedera/node/app/tss/pairings/PairingPublicKey.java 0.00% <0.00%> (ø)
.../hedera/node/app/tss/pairings/SignatureSchema.java 0.00% <0.00%> (ø)
...n/java/com/hedera/node/app/tss/api/TssMessage.java 0.00% <0.00%> (ø)
...n/java/com/hedera/node/app/tss/api/TssShareId.java 0.00% <0.00%> (ø)
...a/com/hedera/node/app/tss/api/TssPrivateShare.java 0.00% <0.00%> (ø)
...va/com/hedera/node/app/tss/api/TssPublicShare.java 0.00% <0.00%> (ø)
...com/hedera/node/app/tss/api/TssShareSignature.java 0.00% <0.00%> (ø)
...hedera/node/app/tss/pairings/FakeFieldElement.java 0.00% <0.00%> (ø)
...edera/node/app/tss/pairings/PairingPrivateKey.java 0.00% <0.00%> (ø)
...hedera/node/app/tss/pairings/FakeGroupElement.java 0.00% <0.00%> (ø)
... and 2 more

Impacted file tree graph

Copy link
Contributor

@mxtartaglia-sl mxtartaglia-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, a couple of comments here:

  1. Linking snapshot dependencies in hedera-services is a risk. This has already bitten me.
  2. The actual code of the library already has a mock (really, it is more like a fake) implementation.
  3. Respecting packages and library names can reduce future rework.
  4. Maybe a better place for the fake is hedera-cryptography?

@MiroslavGatsanoga MiroslavGatsanoga marked this pull request as ready for review October 16, 2024 17:15
@MiroslavGatsanoga MiroslavGatsanoga requested a review from a team October 16, 2024 17:15
@MiroslavGatsanoga MiroslavGatsanoga requested review from a team as code owners October 16, 2024 17:15
@mxtartaglia-sl
Copy link
Contributor

@MiroslavGatsanoga can you have another look to the ParticipantDirectory, we changed id from Integer to Long just now

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MiroslavGatsanoga

@MiroslavGatsanoga MiroslavGatsanoga merged commit 00ceb9a into develop Oct 18, 2024
49 of 50 checks passed
@MiroslavGatsanoga MiroslavGatsanoga deleted the 15492-fake-tss-library-for-testing branch October 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants