-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: create fake TSS library for testing #15908
test: create fake TSS library for testing #15908
Conversation
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Miroslav Gatsanoga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, a couple of comments here:
- Linking snapshot dependencies in hedera-services is a risk. This has already bitten me.
- The actual code of the library already has a mock (really, it is more like a fake) implementation.
- Respecting packages and library names can reduce future rework.
- Maybe a better place for the fake is hedera-cryptography?
hedera-node/hedera-app/src/main/java/com/hedera/node/app/tss/TssLibrary.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
@MiroslavGatsanoga can you have another look to the ParticipantDirectory, we changed id from Integer to Long just now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @MiroslavGatsanoga
Description:
Related issue(s):
#15492
Notes for reviewer:
Checklist