Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use the 'org.web3j.solidity' Gradle plugin to compile contracts #14361

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Jul 23, 2024

Description:

See #7456

TODOs to investigate:

  • make all contracts compile
  • Java code is generated from system contracts
  • Separate task(s) configured to compile with different EVM version for testing

Related issue(s):

Resolves #7456

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC
Copy link
Contributor

Nana-EC commented Oct 1, 2024

@jjohannes any progress on this as 0.55 is complete, will this be in 0.56?
Thanks

@jjohannes
Copy link
Collaborator Author

@Nana-EC sorry this is totally an experiment at this point. I just put a milestone to satisfy the PR checks. Removed it.

@jjohannes jjohannes removed this from the v0.55 milestone Oct 1, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4733608) 97021 63180 65.12%
Head commit (419ed84) 97021 (+0) 63178 (-2) 65.12% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#14361) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.39%. Comparing base (4733608) to head (419ed84).
Report is 88 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #14361      +/-   ##
=============================================
- Coverage      63.39%   63.39%   -0.01%     
+ Complexity     20209    20207       -2     
=============================================
  Files           2539     2539              
  Lines          94256    94256              
  Branches        9859     9859              
=============================================
- Hits           59758    59755       -3     
- Misses         30901    30903       +2     
- Partials        3597     3598       +1     

see 10 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to more easily compile Solidity contracts
3 participants