Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set UTF-8 encoding for Gradle daemon process #13484

Merged
merged 1 commit into from
May 23, 2024
Merged

build: set UTF-8 encoding for Gradle daemon process #13484

merged 1 commit into from
May 23, 2024

Conversation

jjohannes
Copy link
Collaborator

Passing -Dfile.encoding=UTF-8 to the Gradle command effectively has no effect as this only starts a small client process that connects to a (possibly already running) daemon process. These kind of JVM options need to be configured in 'gradle.properties' for the Daemon process.

Description:

Related issue(s):

#11230

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes
build: set UTF-8 encoding for Gradle daemon process
50949d3 
Passing '-Dfile.encoding=UTF-8' to the Gradle command effectively has
no effect as this only starts a small client process that connects
to a (possibly already running) daemon process. These kind of JVM
options need to be configured in 'gradle.properties' for the Daemon
process.

Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes requested review from a team as code owners May 23, 2024 14:12
@jjohannes jjohannes requested review from isavov and leninmehedy May 23, 2024 14:12
@github-actions GitHub Actions
Copy link

Node: Unit Test Results

  2 319 files  ±0    2 319 suites  ±0   3h 21m 27s ⏱️ ±0s
119 360 tests ±0  119 293 ✅ ±0  67 💤 ±0  0 ❌ ±0 
127 919 runs  ±0  127 852 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit 50949d3. ± Comparison against base commit 8b12883.

This pull request removes 358 and adds 121 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=msER1i4Z,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=29618,hostnameExternal=165.49.56.168,portExternalIpv4=29618,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@68fd3cb4,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@4b808,memo=hB60stFZ],
   Address[id=3,nickname=a887nmOv,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=42442,hostnameExternal=10.…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@43dd471f, agrKeyPair=java.security.KeyPair@54e1dc9a, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=MzuDXxxY,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=7293,hostnameExternal=239.110.190.225,portExternalIpv4=7293,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@43db68e8,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@508218dc,memo=KrC0HEOq],
   Address[id=3,nickname=Ds9JrUA2,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=10830,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@37347be1, agrKeyPair=java.security.KeyPair@a1100b7, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=A74IYXBd,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=55077,hostnameExternal=38.67.30.42,portExternalIpv4=55077,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@1240814,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@5ce20013,memo=6AgRZlCk],
   Address[id=2,nickname=aEqMgk5C,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=22404,hostnameExternal=139…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2994a600, agrKeyPair=java.security.KeyPair@2a9f14f8, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=acPb0ESe,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=40082,hostnameExternal=225.237.124.129,portExternalIpv4=40082,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@4adc8924,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@7c4b2837,memo=CBDboFeC],
   Address[id=2,nickname=6hh3TuVI,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=42904,hostnameExterna…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@38f7d1de, agrKeyPair=java.security.KeyPair@65a6ab4, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 3993597839710083868231945175919139090761808006636174301522933223628513549165622405392179927490525437989266705657795380522223992433641724878847443931065713607200936674817049095003247060840820816825608104539722939764219883909214899161…
…

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Token) Results

 19 files   19 suites   6m 29s ⏱️
256 tests 256 ✅ 0 💤 0 ❌
259 runs  259 ✅ 0 💤 0 ❌

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 4s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   1 ✅  7m 32s ⏱️
2 suites  0 💤
2 files    1 ❌

For more details on these failures, see this check.

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Crypto) Results

 22 files   22 suites   13m 10s ⏱️
349 tests 349 ✅ 0 💤 0 ❌
355 runs  355 ✅ 0 💤 0 ❌

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Smart Contract) Results

 66 files   66 suites   22m 23s ⏱️
590 tests 590 ✅ 0 💤 0 ❌
614 runs  614 ✅ 0 💤 0 ❌

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Misc) Results

 50 files   50 suites   23m 7s ⏱️
361 tests 361 ✅ 0 💤 0 ❌
378 runs  378 ✅ 0 💤 0 ❌

Results for commit 50949d3.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Time Consuming) Results

18 tests   18 ✅  22m 6s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 50949d3.

@jjohannes jjohannes merged commit 53f97bc into develop May 23, 2024
47 of 49 checks passed
@jjohannes jjohannes deleted the gradle-utf-8-encoding branch May 23, 2024 15:07
bilyana-gospodinova pushed a commit that referenced this pull request Jun 13, 2024
@jjohannes @bilyana-gospodinova
build: set UTF-8 encoding for Gradle daemon process (#13484)
5917ed2 
Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanklick nathanklick nathanklick approved these changes

@isavov isavov Awaiting requested review from isavov isavov was automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjohannes @nathanklick