-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: do not write test data into source folder #13303
Conversation
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 15s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 10m 26s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 22m 4s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 38m 35s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 43m 24s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 41s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 309 files ±0 2 309 suites ±0 1h 45m 32s ⏱️ - 1h 35m 9s Results for commit 9f1f29a. ± Comparison against base commit 474f5ff. This pull request removes 4005 and adds 3768 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13303 +/- ##
=============================================
- Coverage 61.75% 61.75% -0.01%
Complexity 31252 31252
=============================================
Files 3446 3446
Lines 141289 141289
Branches 14781 14781
=============================================
- Hits 87249 87246 -3
- Misses 50155 50165 +10
+ Partials 3885 3878 -7 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 11m 28s ⏱️ Results for commit 9f1f29a. ♻️ This comment has been updated with latest results. |
b332703
to
7feab13
Compare
This will always invalidate the "test" task after it ran and it will never be UP-TO-DATE. This is, because you change the inputs, in this case the test sources/resources, of the task while it is running. Signed-off-by: Jendrik Johannes <[email protected]>
7feab13
to
9f1f29a
Compare
Signed-off-by: Jendrik Johannes <[email protected]> Signed-off-by: Bilyana Gospodinova <[email protected]>
This will always invalidate the "test" task after it ran and it will never be UP-TO-DATE. This is, because you change the inputs, in this case the test sources/resources, of the task while it is running.
Description:
Related issue(s):
Discovered while working on #11565
Notes for reviewer:
Checklist