Handle invalid expiration time in TokenInfo
#849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickyLB
force-pushed
the
default_expiration_time
branch
4 times, most recently
from
df0df0a to
a6047bf
Compare
RickyLB
changed the title
TokenInfo
Sheng-Long
previously approved these changes
Sep 27, 2024
Signed-off-by: Ricky Saechao <[email protected]>
RickyLB
force-pushed
the
default_expiration_time
branch
from
4da21db to
8eb844e
Compare
Sheng-Long
approved these changes
Sep 27, 2024
RickyLB
changed the title
TokenInfo TokenInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR temporarily handles an integer overflow for tokens that do not have an expiry time. Fetching
TokenInfoexpiry.secondsfrom the mirror node results in aSome(Timestamp { seconds: -9223372036854775808, nanos: 0 })if the token's expiration time is not set.Related issue(s):
Fixes #
Notes for reviewer:
Checklist