Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Protobufs updated #2691

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

This PR updates protobuf files to align with the latest Hedera platform specifications. The Taskfile has been refactored to move the protos from platform directory to the services protos directory. Test failures caused by these changes have been resolved.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ervices directory and fixed tests

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit bf40133 into main Dec 4, 2024
8 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the fix/protobufs-add-platform-folder branch December 4, 2024 13:08
ivaylonikolov7 pushed a commit that referenced this pull request Dec 9, 2024
* fix: Updated protobufs, taskfile to move the platform protos to the services directory and fixed tests

Signed-off-by: ivaylogarnev-limechain <[email protected]>

* fix: Adjusted mocker.js to work with newest protos

Signed-off-by: ivaylogarnev-limechain <[email protected]>

---------

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants