Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tokenTransfer property exposed in AbstractTokenTransferTransaction #2616

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR introduces a getter to expose the tokenTransfers property of AbstractTokenTransferTransaction, making it accessible for use.

Related issue(s):
#2615

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (5d11526) to head (0f7f36a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/token/AbstractTokenTransferTransaction.js 30.43% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.02%     
==========================================
  Files         283      283              
  Lines       71094    71117      +23     
==========================================
+ Hits        60276    60288      +12     
- Misses      10818    10829      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit a563a06 into main Oct 29, 2024
12 of 13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/expose-token-transfer-property branch October 29, 2024 14:11
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransferTransaction: Expose tokenTransfers Property
3 participants