Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export NodeAddressBook class #2599

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

SvetBorislavov
Copy link
Contributor

Description:
This pull request exports the NodeAddressBook class.
This export is essential for enabling serializing and deserializing the NodeAddressBook proto.

Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov SvetBorislavov requested review from a team as code owners October 22, 2024 09:27
Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (3408441) to head (b827183).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
+ Coverage   84.45%   84.47%   +0.01%     
==========================================
  Files         283      283              
  Lines       71088    71089       +1     
==========================================
+ Hits        60037    60050      +13     
+ Misses      11051    11039      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit 0980e57 into main Oct 23, 2024
13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat-export-node-address-book branch October 23, 2024 15:23
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants