(fix) TopicMessageQuery#unsubscribe() attempts to re-subscribe

[Jexsie]

Description:

The unsubscribe method invokes the _call function, which cancels the current active subscription but doesn’t necessarily stop retry attempts, as retries are managed separately in TopicMessageQuery. I have added a check to prevent retries after unsubscribing in the error callback

Screen.Recording.2024-10-09.at.13.29.40.mov

Related issue(s):

Fixes #2222

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[Jexsie]

continuing from #2571
cc @agadzhalov

[agadzhalov]

Hi @Jexsie the commit is still not verified. I can see the commit is signed but are you sure you've setup your GPG keys properly? You can look at this page for more info (Signing commits). Also I can see in your github profile that your previous commits in other directories (example) are not verified too.

[Jexsie]

thanks alot for the support @agadzhalov. Now i see the verified flag

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.45%. Comparing base (34ffa6b) to head (d74190b).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/topic/TopicMessageQuery.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2582   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files         283      283           
  Lines       71038    71046    +8     
=======================================
+ Hits        59993    60002    +9     
+ Misses      11045    11044    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ivaylonikolov7]

Before we can proceed with merging the changes, there is one final task to address. We need to incorporate unit tests for this feature, as the continuous integration (CI) process currently fails without them. As part of our commitment to enhancing code quality, we strive to improve code coverage by adding as many tests as possible whenever new features are implemented.

Could you please create a file named TopicMessageQuery.js within the test/unit directory? The content of this file should be structured as follows:

import { expect } from "chai";

describe("TopicMessageQuery", function () {

    it("should ...", async function () {
    });
});

Additionally, please ensure that the test you write covers lines 441-443. Oone test should suffice for this purpose. If you have any more questions I'd be glad to help.

[Jexsie]

I see we have the TopicMessageMocking file that seems to be mocking the TopicMessageQuery. Won't creating a new file be some sort of duplication, @ivaylonikolov7?

[ivaylonikolov7]

Yeah, fair point. You can use that.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Jexsie]

I have added another test case to handle the scenario @ivaylonikolov7.

[agadzhalov]

LGTM, thank you @Jexsie