Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get file contents #2578

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Get file contents #2578

merged 8 commits into from
Oct 25, 2024

Conversation

b-l-u-e
Copy link
Contributor

@b-l-u-e b-l-u-e commented Oct 14, 2024 •
edited
Loading

Description:
This PR adds a get-file-contents example to demonstrate how to retrieve file contents using the Hedera JavaScript SDK. This functionality is important for developers who need to access and work with file data stored on the Hedera network.

  • Added get-file-contents.js example file
  • Implemented file contents query using FileContentsQuery
  • Included error handling and logging for better developer experience
  • Demonstrated proper use of ECDSA keys or ED25519 keys with the SDK

Related issue(s):

@b-l-u-e b-l-u-e requested review from a team as code owners October 14, 2024 12:42
@b-l-u-e b-l-u-e requested a review from rwalworth October 14, 2024 12:42
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (734aa62) to head (d6514fb).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2578      +/-   ##
==========================================
+ Coverage   84.43%   84.45%   +0.02%     
==========================================
  Files         283      283              
  Lines       71038    71088      +50     
==========================================
+ Hits        59981    60039      +58     
+ Misses      11057    11049       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ivaylogarnev-limechain
ivaylogarnev-limechain reviewed Oct 15, 2024
View reviewed changes
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
ivaylogarnev-limechain
ivaylogarnev-limechain reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts! With those comments addressed the exampled would have finished look.

examples/get-file-contents.js Outdated Show resolved Hide resolved
ivaylogarnev-limechain
ivaylogarnev-limechain reviewed Oct 15, 2024
View reviewed changes
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
@b-l-u-e
logger updated
4858788 
Signed-off-by: b-l-u-e <[email protected]>
ivaylogarnev-limechain
ivaylogarnev-limechain reviewed Oct 16, 2024
View reviewed changes
examples/get-file-contents.js Outdated Show resolved Hide resolved
examples/get-file-contents.js Outdated Show resolved Hide resolved
@b-l-u-e
updated logger
f354af4 
Signed-off-by: b-l-u-e <[email protected]>
@b-l-u-e
updated logger
d6514fb 
Signed-off-by: b-l-u-e <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ivaylogarnev-limechain
ivaylogarnev-limechain approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your efforts!

@b-l-u-e
Copy link
Contributor Author

b-l-u-e commented Oct 17, 2024

@agadzhalov @rwalworth

agadzhalov
agadzhalov approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @b-l-u-e

@b-l-u-e
Copy link
Contributor Author

b-l-u-e commented Oct 17, 2024 •
edited
Loading

@rwalworth please approve

@agadzhalov agadzhalov merged commit 6b0b713 into hashgraph:main Oct 25, 2024
9 checks passed
This was referenced Oct 29, 2024
Merged
Merged
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Oct 30, 2024
Merged
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivaylogarnev-limechain ivaylogarnev-limechain ivaylogarnev-limechain approved these changes

@agadzhalov agadzhalov agadzhalov approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth is a code owner automatically assigned from hashgraph/hedera-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an Example for "Get file contents" functionality
3 participants
@b-l-u-e @agadzhalov @ivaylogarnev-limechain