fix: lock protobufjs version #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 283 283
Lines 71021 71021
==========================================
- Hits 59956 59949 -7
- Misses 11065 11072 +7 ☔ View full report in Codecov by Sentry. |
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
* fix: lock protobufjs version Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update pnpm-lock in proto package Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: b-l-u-e <[email protected]>
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
* fix: lock protobufjs version Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update pnpm-lock in proto package Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: b-l-u-e <[email protected]>
Merged
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Due to a bug in protobufjs version we need to lock
protobufjsversion so we can't groom some of our PRs. This PR updates the package.json and pnpm-lock.files. Deletes pnpm-lock file in the TCK folder due to having both npm-lock and pnpm-lock. Good practices say we should only have one lock file.Checklist