Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement TokenRejectTransaction #2411

Merged
merged 28 commits into from
Aug 1, 2024

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Jul 21, 2024

Description:

This PR implements HIP-904's TokenRejectTransaction. This includes both TokenRejectFlow and TokenRejectTransaction. It also adds integration and unit tests for both types. PR includes an example for the community to see how these transactions are used.

Related issue(s): #2331

Notes for reviewer:
You might need to use local version of @hashgraph/sdk to run example/token-reject.js. For more information look - https://pnpm.io/cli/link

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch from 3f77830 to 92ad7e0 Compare July 22, 2024 20:19
@Petyo-Lukanov Petyo-Lukanov linked an issue Jul 23, 2024 that may be closed by this pull request
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch 5 times, most recently from 814c6ba to 8bbc033 Compare July 26, 2024 11:44
@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review July 26, 2024 13:01
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners July 26, 2024 13:01
@ivaylonikolov7 ivaylonikolov7 requested a review from rwalworth July 26, 2024 13:01
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch 2 times, most recently from bb612ea to 1547aec Compare July 29, 2024 07:10
examples/token-reject.js Outdated Show resolved Hide resolved
examples/token-reject.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch 3 times, most recently from 9f27526 to 497e0c5 Compare July 29, 2024 19:09
examples/token-reject.js Outdated Show resolved Hide resolved
examples/token-reject.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/TokenRejectIntegrationTest.js Outdated Show resolved Hide resolved
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch from 497e0c5 to ab0d80a Compare July 30, 2024 08:21
examples/token-reject.js Outdated Show resolved Hide resolved
examples/token-reject.js Outdated Show resolved Hide resolved
examples/token-reject.js Outdated Show resolved Hide resolved
examples/token-reject.js Outdated Show resolved Hide resolved
src/token/TokenRejectFlow.js Outdated Show resolved Hide resolved
src/token/TokenRejectFlow.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
src/token/TokenRejectTransaction.js Outdated Show resolved Hide resolved
src/token/TokenReference.js Outdated Show resolved Hide resolved
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/hedera-904-token-reject branch 3 times, most recently from b6440b8 to a3417c8 Compare July 30, 2024 10:43
ivaylonikolov7 and others added 8 commits August 1, 2024 17:27
Signed-off-by: Ivaylo Nikolov <[email protected]>
* chore: address initial pain points

Signed-off-by: Ivan Ivanov <[email protected]>

* chore: bump grpc-js version

Signed-off-by: Ivan Ivanov <[email protected]>

* fix

Signed-off-by: svetoslav-nikol0v <[email protected]>

* remove example

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: formatting

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix

Signed-off-by: svetoslav-nikol0v <[email protected]>

* revert: grpc old version

Signed-off-by: svetoslav-nikol0v <[email protected]>

* revert: pnpm-lock file

Signed-off-by: svetoslav-nikol0v <[email protected]>

* revert: package-lock file

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Co-authored-by: Ivan Ivanov <[email protected]>
Signed-off-by: Iliya Savov <[email protected]>
Co-authored-by: Iliya Savov <[email protected]>
Co-authored-by: Svet <[email protected]>
@agadzhalov agadzhalov force-pushed the feat/hedera-904-token-reject branch from c22561f to cada4d4 Compare August 1, 2024 14:27
@agadzhalov agadzhalov requested review from a team as code owners August 1, 2024 14:27
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-904: TokenRejectTransaction
6 participants