fix: 2355 preproduction releases are being marked stable instead of beta #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
…leases-are-being-marked-stable-instead-of-beta Signed-off-by: Roger Barker <[email protected]>
Logic was inverted. Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
…-stable-instead-of-beta Signed-off-by: Roger Barker <[email protected]>
rbarkerSL
requested review from
dalvizu,
jeromy-cannon,
rwalworth and
nathanklick
Signed-off-by: Roger Barker <[email protected]>
|
nathanklick
approved these changes
Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
- Coverage 76.49% 76.15% -0.35%
==========================================
Files 304 308 +4
Lines 75800 77354 +1554
==========================================
+ Hits 57986 58908 +922
- Misses 17814 18446 +632 ☔ View full report in Codecov by Sentry. |
rbarkerSL
deleted the
2355-preproduction-releases-are-being-marked-stable-instead-of-beta
branch
This was referenced Aug 31, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes issue with publish_release.yaml where using
needsinstead ofstepswithin a given job.