-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom derivation paths in Mnemonic ECDSA private key derivation #2341
feat: custom derivation paths in Mnemonic ECDSA private key derivation #2341
Conversation
Signed-off-by: Brendan Graetz <[email protected]>
Quality Gate failedFailed conditions |
…tionPath - based on review by @svetoslav-nikol0v - hiero-ledger#2341 (review) Signed-off-by: Brendan Graetz <[email protected]>
91bf97a
to
1708ea5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
- Coverage 76.49% 75.99% -0.51%
==========================================
Files 304 230 -74
Lines 75800 58047 -17753
==========================================
- Hits 57986 44114 -13872
+ Misses 17814 13933 -3881 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brendan Graetz <[email protected]>
@svetoslav-nikol0v I've addressed your feedback in 5a5b32d2 Attempt to increase code coverage of Further context: https://swirldslabs.slack.com/archives/C0453UVBR42/p1719635439040999?thread_ts=1717061977.081859&cid=C0453UVBR42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
What
Why
Related issue(s):
Fixes: hiero-ledger/hiero-sdk-java#1263 (comment)
Notes for reviewer:
Checklist