Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom derivation paths in Mnemonic ECDSA private key derivation #2341

Merged

Conversation

bguiz
Copy link
Contributor

@bguiz bguiz commented Jun 12, 2024

Description:

What

  • Add custom derivation path capability

Why

Related issue(s):

Fixes: hiero-ledger/hiero-sdk-java#1263 (comment)

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@bguiz bguiz requested review from a team as code owners June 12, 2024 05:31
@bguiz bguiz requested a review from rwalworth June 12, 2024 05:31
@bguiz bguiz changed the title feat: custom derivation paths in Menmonic ECDSA private key derivation feat: custom derivation paths in Mnemonic ECDSA private key derivation Jun 12, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@SimiHunjan SimiHunjan added this to the 2.49.0 milestone Jun 24, 2024
@svetoslav-nikol0v svetoslav-nikol0v removed the request for review from rwalworth June 25, 2024 08:19
@SimiHunjan SimiHunjan modified the milestones: 2.49.0, 2.48.0 Jun 25, 2024
src/Mnemonic.js Outdated Show resolved Hide resolved
src/Mnemonic.js Outdated Show resolved Hide resolved
src/Mnemonic.js Outdated Show resolved Hide resolved
@bguiz bguiz force-pushed the feat/custom-derivation-paths branch from 91bf97a to 1708ea5 Compare June 28, 2024 05:48
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 54.66667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (5c428d4) to head (46cab9b).
Report is 82 commits behind head on main.

Current head 46cab9b differs from pull request most recent head 5a5b32d

Please upload reports for the commit 5a5b32d to get more accurate results.

Files Patch % Lines
src/Mnemonic.js 54.66% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   76.49%   75.99%   -0.51%     
==========================================
  Files         304      230      -74     
  Lines       75800    58047   -17753     
==========================================
- Hits        57986    44114   -13872     
+ Misses      17814    13933    -3881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bguiz
Copy link
Contributor Author

bguiz commented Jun 29, 2024

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromMnemonic returns a private key which shouldn't be used
4 participants