Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: handling and externalisation improvements for account nonce updates #2176

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Added signer_nonce field defined in v0.47.0 proto which is needed for HIP-844.

Related issue: #2108

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit a58be38 into release/v2.42.0 Feb 29, 2024
7 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2108-add-hip-844-handling-and-externalisation-improvements-for-account-nonce-updates-2 branch February 29, 2024 15:09
svetoslav-nikol0v added a commit that referenced this pull request Mar 12, 2024
* version

Signed-off-by: svetoslav-nikol0v <[email protected]>

* release notes

Signed-off-by: svetoslav-nikol0v <[email protected]>

* stringify the value

Signed-off-by: svetoslav-nikol0v <[email protected]>

* address books update

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: update version, changelog, address books

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feature: handling and externalisation improvements for account nonce updates (#2176)

* chore: all necessary stuff for release

Signed-off-by: svetoslav-nikol0v <[email protected]>

* feature: add signerNonce field

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: remove .only

Signed-off-by: svetoslav-nikol0v <[email protected]>

* fix: release workflow

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: skip the test suit for ethereum transaction

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: add more details

Signed-off-by: svetoslav-nikol0v <[email protected]>

* chore: typo

Signed-off-by: svetoslav-nikol0v <[email protected]>

---------

Signed-off-by: svetoslav-nikol0v <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP 844: Handling and externalisation improvements for account nonce updates
2 participants