Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added alias utils for parsing from/to public address #2066

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Dec 19, 2023

Description:
Add utils for parsing alias to a public key and vice versa.

Related issue(s):

Fixes #2063

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c4438cb) 76.17% compared to head (b5f5f0e) 76.21%.

Files Patch % Lines
src/EntityIdHelper.js 92.64% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2066      +/-   ##
===========================================
+ Coverage    76.17%   76.21%   +0.04%     
===========================================
  Files          304      305       +1     
  Lines        75885    76064     +179     
===========================================
+ Hits         57804    57971     +167     
- Misses       18081    18093      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ochikov <[email protected]>
…e Buffer is only supported in Node.js

Signed-off-by: ochikov <[email protected]>
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ochikov ochikov merged commit 229fead into develop Jan 2, 2024
9 of 11 checks passed
@ochikov ochikov deleted the add-alias-utils branch January 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add new methods for conversion between Ed25519 public key and long account ID (as defined in HIP-32)
2 participants