Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing client operator with a getter #1970

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

rokn
Copy link
Contributor

@rokn rokn commented Oct 10, 2023

Description:
This PR exposes the client operator for easier access, to enable signing arbitrary data with it.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3ce2e32) 77.02% compared to head (b859319) 76.49%.
Report is 3 commits behind head on develop.

❗ Current head b859319 differs from pull request most recent head 6a09bf5. Consider uploading reports for the commit 6a09bf5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1970      +/-   ##
===========================================
- Coverage    77.02%   76.49%   -0.53%     
===========================================
  Files          265      304      +39     
  Lines        66273    75800    +9527     
===========================================
+ Hits         51048    57986    +6938     
- Misses       15225    17814    +2589     
Files Coverage Δ
src/token/AssessedCustomFee.js 82.46% <100.00%> (+30.33%) ⬆️
src/token/TokenWipeTransaction.js 92.73% <100.00%> (+11.33%) ⬆️
src/transaction/TransactionRecord.js 91.98% <100.00%> (+18.23%) ⬆️
src/client/Client.js 83.04% <71.42%> (-0.11%) ⬇️

... and 195 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rokn rokn merged commit 8356d64 into develop Oct 11, 2023
10 checks passed
@rokn rokn deleted the client-operator-expose branch October 11, 2023 09:09
@Petyo-Lukanov Petyo-Lukanov linked an issue Oct 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing client operator with a getter
3 participants