Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration tests #1896

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix integration tests #1896

merged 1 commit into from
Sep 25, 2023

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Sep 24, 2023

Description:
Fix integration tests

Related issue(s):

Fixes #1895

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ochikov <[email protected]>
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 66.48% and project coverage change: +6.43% 🎉

Comparison is base (cab7be2) 76.94% compared to head (4a2db71) 83.38%.
Report is 132 commits behind head on develop.

❗ Current head 4a2db71 differs from pull request most recent head e429f13. Consider uploading reports for the commit e429f13 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
+ Coverage    76.94%   83.38%   +6.43%     
===========================================
  Files          292      304      +12     
  Lines        72743    75789    +3046     
===========================================
+ Hits         55971    63194    +7223     
+ Misses       16772    12595    -4177     
Files Changed Coverage Δ
...ckages/cryptography/src/encoding/base64.browser.js 0.00% <0.00%> (ø)
packages/cryptography/src/primitive/aes.browser.js 0.00% <0.00%> (ø)
packages/cryptography/src/primitive/aes.native.js 0.00% <0.00%> (ø)
...ckages/cryptography/src/primitive/bip32.browser.js 0.00% <0.00%> (ø)
...ackages/cryptography/src/primitive/bip32.native.js 0.00% <0.00%> (ø)
src/browser.js 0.00% <0.00%> (ø)
src/channel/NativeChannel.js 0.00% <0.00%> (ø)
src/channel/WebChannel.js 0.00% <0.00%> (ø)
src/client/NativeClient.js 0.00% <0.00%> (ø)
src/client/WebClient.js 0.00% <0.00%> (ø)
... and 209 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ochikov ochikov force-pushed the fix/integration-tests branch from 18db648 to e429f13 Compare September 24, 2023 18:36
@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze merged commit 803ff58 into develop Sep 25, 2023
16 of 17 checks passed
@petreze petreze deleted the fix/integration-tests branch September 25, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests are failing
2 participants