Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the insecure port of mirror nodes #1535

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Mar 31, 2023

Description:
Changes:

  • transportSecurity moved from ManagedNetwork to Network
  • toInsecure() and toSecure() moved from ManagedNode to Node

Related issue(s):

Fixes #1446

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: dikel <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit 1fd0db4 into develop Apr 4, 2023
@ochikov ochikov deleted the fix/remove-mirror-node-insecure-port branch April 4, 2023 12:29
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* fix: remove the insecure port of mirror nodes

Signed-off-by: dikel <[email protected]>

* run linter

Signed-off-by: dikel <[email protected]>

---------

Signed-off-by: dikel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mirror node endpoints
2 participants