Fix web proxy #1395
Merged
Fix web proxy #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ochikov <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
ochikov
requested changes
Jan 13, 2023
ochikov
approved these changes
Jan 13, 2023
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Codecov ReportBase: 83.42% // Head: 83.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1395 +/- ##
===========================================
- Coverage 83.42% 83.35% -0.08%
===========================================
Files 292 295 +3
Lines 72867 73047 +180
===========================================
+ Hits 60790 60885 +95
- Misses 12077 12162 +85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Petar Tonev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* web proxy issues tracking Signed-off-by: ochikov <[email protected]> * added nodeAccountIds unlocking Signed-off-by: Petar Tonev <[email protected]> * unhealthy nodes now are handled correctly Signed-off-by: Petar Tonev <[email protected]> * added additional proxies urls and after task build refactoring Signed-off-by: Petar Tonev <[email protected]> * add urls to a new client constants file Signed-off-by: Petar Tonev <[email protected]> * fix integration tests Signed-off-by: Petar Tonev <[email protected]> * handle some corner cases Signed-off-by: Petar Tonev <[email protected]> Signed-off-by: ochikov <[email protected]> Signed-off-by: Petar Tonev <[email protected]> Co-authored-by: ochikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the issue where the SDK does not check for any HTTP errors when trying to connect to some of the node proxies. Also there is a fix for a corner case if the random mechanism chooses the same node twice in a row and puts it inside the healthy nodes list
Related issue(s):
Fixes #1362 #1363
Checklist