Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the addressbook update to be 24 hours #1359

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Dec 19, 2022

Signed-off-by: ochikov [email protected]

Description:
Update the network update time period to 24 hours.

Related issue(s):

Fixes #1342

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 83.54% // Head: 83.42% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (f579380) compared to base (cc1d431).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f579380 differs from pull request most recent head 9186f29. Consider uploading reports for the commit 9186f29 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1359      +/-   ##
===========================================
- Coverage    83.54%   83.42%   -0.12%     
===========================================
  Files          292      292              
  Lines        72871    72867       -4     
===========================================
- Hits         60878    60789      -89     
- Misses       11993    12078      +85     
Impacted Files Coverage Δ
src/network/AddressBookQuery.js 69.14% <ø> (-21.70%) ⬇️
src/client/Client.js 85.87% <100.00%> (-2.80%) ⬇️
src/channel/NodeMirrorChannel.js 97.14% <0.00%> (-2.86%) ⬇️
src/Cache.js 79.50% <0.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit aa11eea into develop Dec 19, 2022
@ochikov ochikov deleted the fix/update-address-book-time branch December 19, 2022 16:47
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* Update the addressbook update to be 24 hours

Signed-off-by: ochikov <[email protected]>

* Fix the common_js tests

Signed-off-by: ochikov <[email protected]>

Signed-off-by: ochikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error getting nodes from mirror for file 0.0.102 during attempt 0
2 participants