Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing connection issues #1355

Closed
wants to merge 1 commit into from
Closed

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Dec 15, 2022

Description:
This PR fixes connection issues with the previewnet.

Related issue(s):

Fixes #1342

Notes for reviewer:

N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 83.54% // Head: 83.54% // No change to project coverage 👍

Coverage data is based on head (d880996) compared to base (cc1d431).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1355   +/-   ##
========================================
  Coverage    83.54%   83.54%           
========================================
  Files          292      292           
  Lines        72871    72871           
========================================
  Hits         60878    60878           
  Misses       11993    11993           
Impacted Files Coverage Δ
src/client/NodeClient.js 82.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ochikov
Copy link
Contributor

ochikov commented Dec 16, 2022

Hello @Neurone,
as I described in #1342 the connection issue is not related to the URL. It is related to the too frequent fetching of the Address Book. If we change to this URL, soon the issue will persist. Why do we need to switch to this URL at all? We are working on changing the interval of fetching the Address Book and it will be released with the new version.
For example this issue is known also on Mainnet as well as on Testnet

@steven-sheehy
Copy link
Member

I agree, this should be closed. See my comment on ticket.

@ochikov ochikov closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error getting nodes from mirror for file 0.0.102 during attempt 0
3 participants