Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix and improve taskfiles workflow #1283

Merged
merged 3 commits into from
Oct 14, 2022
Merged

bug: fix and improve taskfiles workflow #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d496847
petreze Oct 5, 2022
a531901
commented the lint task
petreze Oct 5, 2022
bc0dfa3
bug: added and enhanced some of the tasks
petreze Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,13 @@ tasks:
status:
- ./check_yalc_dep.sh @hashgraph/proto

"build:proto":
cmds:
- task: "proto:build"

install:
deps:
- "build:proto"
- "install:cryptography:local"
- "install:proto:local"
cmds:
Expand Down
4 changes: 2 additions & 2 deletions packages/proto/Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tasks:
# TODO: How do we support this build step when we update the
# protobufs? Currently, this step results in reseting any protobuf
# updates we may have.
# - git submodule update --init
- git submodule update --init
status:
- test -d packages/proto/src/proto

Expand All @@ -44,7 +44,7 @@ tasks:
- ./node_modules/.bin/babel src -d lib
- ./node_modules/.bin/copyfiles -u 1 src/index.d.ts src/proto.d.ts lib/ > /dev/null
# This is necessary to correctly run browser tests with an unpublished proto package
- ../../node_modules/.bin/yalc publish > /dev/null
# - ../../node_modules/.bin/yalc publish > /dev/null

clean:
cmds:
Expand Down