chore: update build.yml #1895
Merged
chore: update build.yml #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Iliya Savov <[email protected]>
Signed-off-by: Iliya Savov <[email protected]>
rbarkerSL
requested changes
Jul 17, 2024
|
Please create a github issue to update the repository settings for the required checks on PRs / pushes to main. After this PR merges the existing checks will not be valid (code compiles / example code tests / unit tests). We will need to add in checks the new named CI/CD items. |
Signed-off-by: Nikita Lebedev <[email protected]>
rbarkerSL
approved these changes
Jul 17, 2024
|
@rbarkerSL thanks for review. |
|
isavov
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some GitHub Action names are irrelevant (like
Unit Tests, because it does execute integration tests as well)-- Current PR addressed this issue.Changes were inspired by setup in Go SDK.
Related issue(s):
Closes #1894
Notes for reviewer:
build.ymlfiles can be revisited in SDKs as a follow up.