-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HIP-657): Mutable metadata fields for dynamic NFTs #1748
feat(HIP-657): Mutable metadata fields for dynamic NFTs #1748
Conversation
|
Signed-off-by: Nikita Lebedev <[email protected]>
ffcb87d
to
6464389
Compare
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from nit, LGTM
sdk/src/main/java/com/hedera/hashgraph/sdk/TokenUpdateNftsTransaction.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Nikita Lebedev <[email protected]>
…-for-dynamic-nfts
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
This reverts commit db02df0. Signed-off-by: Nikita Lebedev <[email protected]
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
…r-dynamic-nfts # Conflicts: # sdk/src/main/java/com/hedera/hashgraph/sdk/Status.java # sdk/src/main/proto/response_code.proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: SimiHunjan <[email protected]> Signed-off-by: Nikita Lebedev <[email protected]> Co-authored-by: Nikita Lebedev <[email protected]>
|
Description:
This PR implements HIP-657.
Side-effects of this PR:
TokenCreateTransaction
unit tests were improved;pauseKey
to some integration tests (some integration tests are running with all keys, except of this one, but better to address it more deeply in other issise)Related issue(s):
Fixes #1496
Checklist