Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HIP-657): Mutable metadata fields for dynamic NFTs #1748

Merged

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Mar 8, 2024

Description:
This PR implements HIP-657.

Side-effects of this PR:

  • protobuf update;
  • TokenCreateTransaction unit tests were improved;
  • added pauseKey to some integration tests (some integration tests are running with all keys, except of this one, but better to address it more deeply in other issise)

Related issue(s):
Fixes #1496

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarqubecloud bot commented Mar 8, 2024

@thenswan thenswan force-pushed the 01496-add-hip-657-mutable-metadata-fields-for-dynamic-nfts branch from ffcb87d to 6464389 Compare March 14, 2024 12:48
@Petyo-Lukanov Petyo-Lukanov linked an issue Mar 15, 2024 that may be closed by this pull request
8 tasks
@0xivanov 0xivanov self-requested a review March 18, 2024 11:32
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from nit, LGTM

agadzhalov
agadzhalov previously approved these changes Mar 21, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agadzhalov agadzhalov marked this pull request as ready for review March 21, 2024 14:25
@agadzhalov agadzhalov requested a review from SimiHunjan as a code owner March 21, 2024 14:25
Signed-off-by: Nikita Lebedev <[email protected]>
This reverts commit db02df0.

Signed-off-by: Nikita Lebedev <[email protected]
Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
…r-dynamic-nfts

# Conflicts:
#	sdk/src/main/java/com/hedera/hashgraph/sdk/Status.java
#	sdk/src/main/proto/response_code.proto
agadzhalov
agadzhalov previously approved these changes Apr 19, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nikita Lebedev <[email protected]>
thenswan and others added 2 commits April 22, 2024 16:20
Copy link

@thenswan thenswan merged commit dfa44ac into main Apr 23, 2024
7 checks passed
@thenswan thenswan deleted the 01496-add-hip-657-mutable-metadata-fields-for-dynamic-nfts branch April 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-657 Mutable metadata fields for dynamic NFTs
4 participants