Fix sonar issues #9941
Fix sonar issues #9941
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9941 +/- ##
============================================
+ Coverage 92.25% 92.26% +0.01%
- Complexity 7821 7822 +1
============================================
Files 953 953
Lines 32730 32722 -8
Branches 4146 4140 -6
============================================
- Hits 30195 30192 -3
+ Misses 1559 1557 -2
+ Partials 976 973 -3 ☔ View full report in Codecov by Sentry. |
sdimitrov9
force-pushed
the
9010-fix-more-sonar-issues
branch
from
ef85eee to
c249f7c
Compare
Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
9010-fix-more-sonar-issues
branch
from
c249f7c to
ff1b797
Compare
|
| @@ -224,6 +224,7 @@ public void verifyFungibleTokenIsNotFrozen() { | |||
| } | |||
|
|
|||
| @And("verify non fungible token isn't frozen") | |||
| @And("check if non fungible token is unfrozen") | |||
There was a problem hiding this comment.
Instead of having two step names for the same method it would be better to consolidate the step names in the .feature file to one.
| @@ -129,6 +129,7 @@ public void verifyMirrorAPIContractResponses(int status) { | |||
| } | |||
|
|
|||
| @Then("the mirror node REST API should verify the deployed contract entity by eth call") | |||
| @Then("the mirror node REST API should verify the ethereum called contract function") | |||
There was a problem hiding this comment.
Instead of having two step names for the same method it would be better to consolidate the step names in the .feature file to one.
Description:
Fix dozens sonar issues.
Related issue(s):
Partially fixes 9010
Checklist